Drop src/libsecp256k1-config.h #1178

1. 
   hebasto commented at 3:03 pm on December 14, 2022: member

   Cherry-picked the first commit from #1142 and addressed a comment.
2. hebasto cross-referenced this on Dec 14, 2022 from issue Add section on configuration flags to README by ZenulAbidin
3. in configure.ac:293 in e129a39bf8 outdated

   292@@ -293,10 +293,10 @@ int128_struct)
   293   AC_DEFINE(USE_FORCE_WIDEMUL_INT128_STRUCT, 1, [Define this symbol to force the use of the structure for simulating (unsigned) int128 based wide multiplication])
   

   ---

   ---

   

   real-or-random commented at 6:10 pm on December 14, 2022:

   This newly added AC_DEFINE should be changed, too.

   ---

   

   hebasto commented at 1:10 pm on December 15, 2022:

   Thanks! Updated.
4. Remove dependency on `src/libsecp256k1-config.h`

   This change eases the use of alternate build systems by moving
   the variables in `src/libsecp256k1-config.h` to compiler macros
   for each invocation, preventing duplication of these variables
   for each build system.
   
   Co-authored-by: Ali Sherief <ali@notatether.com>

   b627ba7050
5. Drop no longer relevant files from `.gitignore` ad8647f548
6. hebasto force-pushed on Dec 15, 2022
7. 
   hebasto commented at 1:09 pm on December 15, 2022: member

   Updated e129a39bf83eb05911b2c336feaff1580693127e -> ad8647f548cba9c367f837fcdb76de280fa93c19 (pr1178.01 -> pr1178.02, diff):

   • addressed @real-or-random’s comment
8. 
   hebasto commented at 1:12 pm on December 15, 2022: member

   Not sure about this AC_DEFINE macro https://github.com/bitcoin-core/secp256k1/blob/9a8d65f07f171b07bd7a33828dce073d819fbdef/build-aux/m4/bitcoin_secp.m4#L23
9. 
   real-or-random commented at 5:40 pm on December 15, 2022: contributor

   Not sure about this AC_DEFINE macro

   https://github.com/bitcoin-core/secp256k1/blob/9a8d65f07f171b07bd7a33828dce073d819fbdef/build-aux/m4/bitcoin_secp.m4#L23

   I suggest removing it, it’s unused, and also confusing because we use the VALGRIND macro.

10. Do not define unused `HAVE_VALGRIND` macro 9c5a4d21bb
11. 
    hebasto commented at 8:07 pm on December 15, 2022: member

    I suggest removing it, it’s unused, and also confusing because we use the VALGRIND macro.

    Done.

12. real-or-random approved
13. 
    real-or-random commented at 10:54 pm on December 15, 2022: contributor

    utACK 9c5a4d21bbe820173e361211f42d5fee4765944c
14. 
    sipa commented at 3:42 am on December 20, 2022: contributor

    utACK 9c5a4d21bbe820173e361211f42d5fee4765944c
15. sipa merged this on Dec 20, 2022
16. sipa closed this on Dec 20, 2022

    ---

17. real-or-random cross-referenced this on Dec 20, 2022 from issue Add support for msan instead of valgrind (for memcheck and ctime test) by sipa
18. hebasto deleted the branch on Dec 20, 2022
19. hebasto cross-referenced this on Dec 20, 2022 from issue build: Add CMake-based build system by hebasto
20. sipa cross-referenced this on Dec 29, 2022 from issue Signed-digit multi-comb ecmult_gen algorithm by sipa
21. in Makefile.am:151 in 9c5a4d21bb

    147@@ -148,7 +148,7 @@ endif
    148 if USE_EXAMPLES
    149 noinst_PROGRAMS += ecdsa_example
    150 ecdsa_example_SOURCES = examples/ecdsa.c
    151-ecdsa_example_CPPFLAGS = -I$(top_srcdir)/include
    152+ecdsa_example_CPPFLAGS = -I$(top_srcdir)/include $(SECP_CONFIG_DEFINES)
    

    ---

    ---

    

    real-or-random commented at 4:35 pm on December 30, 2022:

    Shouldn’t these be dropped for the example, because a user application shouldn’t need our defines?

    ---

    

    hebasto commented at 5:37 pm on January 3, 2023:

    See #1185.
22. hebasto cross-referenced this on Jan 3, 2023 from issue Drop `SECP_CONFIG_DEFINES` from examples by hebasto
23. real-or-random referenced this in commit 2a39ac162e on Jan 3, 2023
24. sipa cross-referenced this on Jan 5, 2023 from issue Abstract out and merge all the magnitude/normalized logic by sipa
25. dhruv referenced this in commit 78b5ddf28b on Jan 11, 2023
26. dhruv referenced this in commit 215394a1d5 on Jan 11, 2023
27. dhruv referenced this in commit 6aeec7c530 on Jan 13, 2023
28. dhruv referenced this in commit 863cf15b37 on Jan 13, 2023
29. dhruv referenced this in commit 61f942a096 on Jan 23, 2023
30. hebasto cross-referenced this on Jan 28, 2023 from issue Drop no longer used Autoheader macros by hebasto
31. sipa referenced this in commit 1bff200588 on Jan 30, 2023
32. dhruv referenced this in commit 4d33046ce3 on Feb 1, 2023
33. dhruv referenced this in commit 55e7f2cf2b on Feb 2, 2023
34. stratospher referenced this in commit 647f63669e on Feb 6, 2023
35. dhruv referenced this in commit a4351c0df6 on Feb 20, 2023
36. stratospher referenced this in commit 23f825fc8b on Feb 21, 2023
37. roconnor-blockstream referenced this in commit 2ed20b8931 on Feb 25, 2023
38. roconnor-blockstream referenced this in commit ddbe949ce4 on Mar 1, 2023
39. roconnor-blockstream referenced this in commit 6583a74aea on Mar 2, 2023
40. jonasnick cross-referenced this on Mar 7, 2023 from issue Update Changelog by jonasnick
41. hebasto referenced this in commit 7c0cc5d976 on Mar 7, 2023
42. roconnor-blockstream referenced this in commit 50ff8e8ac4 on Mar 7, 2023
43. dhruv referenced this in commit a5df79db12 on Mar 7, 2023
44. dhruv referenced this in commit 77b510d84c on Mar 7, 2023
45. sipa referenced this in commit 763079a3f1 on Mar 8, 2023
46. roconnor-blockstream referenced this in commit 6602db253d on Mar 10, 2023
47. div72 referenced this in commit 945b094575 on Mar 14, 2023
48. vmta referenced this in commit e1120c94a1 on Jun 4, 2023
49. vmta referenced this in commit 8f03457eed on Jul 1, 2023
50. sipa cross-referenced this on Jul 5, 2023 from issue Gitignore auto-generated Secp256k1 files by kibnakamoto
51. jonasnick cross-referenced this on Jul 19, 2023 from issue Upstream PRs 1174, 1154, 1178, 1177, 1171, 1158, 1183, 1185, 1186, 1188, 1187 by jonasnick

Contributors
hebasto real-or-random sipa