Bugfix: pass SECP_CONFIG_DEFINES to bench compilation #1183

pull sipa wants to merge 1 commits into bitcoin-core:master from sipa:202212_fix_bench_cppflags changing 1 files +1 −0
  1. sipa commented at 8:32 pm on December 29, 2022: contributor
  2. Bugfix: pass SECP_CONFIG_DEFINES to bench compilation c0a555b2ae
  3. real-or-random approved
  4. real-or-random commented at 11:07 am on December 30, 2022: contributor

    utACK c0a555b2ae35d5cca0481ecdd4cff5a1ae314283

    We could also add an AM_CPPFLAGS that will be used as a default for binaries that don’t have a corresponding _CPPFLAGS variable. But I’m not convinced that this is a good idea, I don’t think there’s a very good default… It’s probably better to keep setting the CPPFLAGS explicitly for every binary.

  5. apoelstra approved
  6. apoelstra commented at 9:44 pm on December 31, 2022: contributor
    ACK c0a555b2ae35d5cca0481ecdd4cff5a1ae314283
  7. real-or-random merged this on Jan 2, 2023
  8. real-or-random closed this on Jan 2, 2023

  9. dhruv referenced this in commit 4d33046ce3 on Feb 1, 2023
  10. dhruv referenced this in commit 55e7f2cf2b on Feb 2, 2023
  11. stratospher referenced this in commit 647f63669e on Feb 6, 2023
  12. dhruv referenced this in commit a4351c0df6 on Feb 20, 2023
  13. stratospher referenced this in commit 23f825fc8b on Feb 21, 2023
  14. hebasto referenced this in commit 7c0cc5d976 on Mar 7, 2023
  15. dhruv referenced this in commit a5df79db12 on Mar 7, 2023
  16. dhruv referenced this in commit 77b510d84c on Mar 7, 2023
  17. sipa referenced this in commit 763079a3f1 on Mar 8, 2023
  18. div72 referenced this in commit 945b094575 on Mar 14, 2023
  19. vmta referenced this in commit e1120c94a1 on Jun 4, 2023
  20. vmta referenced this in commit 8f03457eed on Jul 1, 2023
  21. jonasnick cross-referenced this on Jul 19, 2023 from issue Upstream PRs 1174, 1154, 1178, 1177, 1171, 1158, 1183, 1185, 1186, 1188, 1187 by jonasnick

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-30 01:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me