tests: Add noverify_tests which is like tests but without VERIFY #1188

1. 
   real-or-random commented at 10:39 am on January 5, 2023: contributor

   mentioned in #1037 (comment)

   Let’s see how this affects CI time

2. real-or-random force-pushed on Jan 5, 2023
3. 
   real-or-random commented at 1:06 pm on January 5, 2023: contributor

   Let’s see how this affects CI time

   Less than I expected:

   master: https://cirrus-ci.com/build/6730654054875136 this PR: https://cirrus-ci.com/build/4723750860488704

   What do you think? Is this useful? If yes, should we just keep it as is or reduce the test iterations?

4. 
   sipa commented at 8:41 pm on January 5, 2023: contributor

   I think we can leave it as-is. I think only the duration of the longest-running CI job really matters, and that seems barely affected.
5. 
   real-or-random commented at 10:47 am on January 6, 2023: contributor

   I think we can leave it as-is. I think only the duration of the longest-running CI job really matters, and that seems barely affected.

   Indeed. Ready for review then.

6. real-or-random marked this as ready for review on Jan 6, 2023
7. apoelstra approved
8. 
   apoelstra commented at 2:21 pm on January 6, 2023: contributor

   ACK 9953ce8d030d62f0e5ae4a4ae4f25a151d602992
9. 
   sipa commented at 4:26 am on January 7, 2023: contributor

   Instead of disabling -DVERIFY for tests if coverage is enabled, maybe just disable tests (and leave noverify_tests)?
10. tests: Add noverify_tests which is like tests but without VERIFY 203760023c
11. real-or-random force-pushed on Jan 7, 2023
12. 
    real-or-random commented at 10:13 pm on January 7, 2023: contributor

    Instead of disabling -DVERIFY for tests if coverage is enabled, maybe just disable tests (and leave noverify_tests)?

    done

13. apoelstra approved
14. 
    apoelstra commented at 11:18 pm on January 8, 2023: contributor

    ACK 203760023c60d250cb5937e27bcf29e7a829096c
15. 
    sipa commented at 4:06 pm on January 9, 2023: contributor

    ACK 203760023c60d250cb5937e27bcf29e7a829096c
16. sipa merged this on Jan 9, 2023
17. sipa closed this on Jan 9, 2023

    ---

18. sipa cross-referenced this on Jan 9, 2023 from issue Add support for msan instead of valgrind (for memcheck and ctime test) by sipa
19. hebasto cross-referenced this on Jan 13, 2023 from issue Add `noverify_tests` to `.gitignore` by hebasto
20. real-or-random referenced this in commit ff8edf89e2 on Jan 14, 2023
21. hebasto cross-referenced this on Jan 17, 2023 from issue build: Add CMake-based build system by hebasto
22. dhruv referenced this in commit 4d33046ce3 on Feb 1, 2023
23. dhruv referenced this in commit 55e7f2cf2b on Feb 2, 2023
24. stratospher referenced this in commit 647f63669e on Feb 6, 2023
25. dhruv referenced this in commit a4351c0df6 on Feb 20, 2023
26. stratospher referenced this in commit 23f825fc8b on Feb 21, 2023
27. real-or-random cross-referenced this on Mar 7, 2023 from issue Update Changelog by jonasnick
28. hebasto referenced this in commit 7c0cc5d976 on Mar 7, 2023
29. dhruv referenced this in commit a5df79db12 on Mar 7, 2023
30. dhruv referenced this in commit 77b510d84c on Mar 7, 2023
31. sipa referenced this in commit 763079a3f1 on Mar 8, 2023
32. hebasto cross-referenced this on Mar 14, 2023 from issue build: Meta-issue for follow-ups to initial CMake merge (#1113) by hebasto
33. div72 referenced this in commit 945b094575 on Mar 14, 2023
34. vmta referenced this in commit e1120c94a1 on Jun 4, 2023
35. vmta referenced this in commit 8f03457eed on Jul 1, 2023
36. jonasnick cross-referenced this on Jul 19, 2023 from issue Upstream PRs 1174, 1154, 1178, 1177, 1171, 1158, 1183, 1185, 1186, 1188, 1187 by jonasnick

Contributors
real-or-random sipa apoelstra