Make all non-API functions (except main) static #1190

1. 
   sipa commented at 5:03 pm on January 9, 2023: contributor
2. Make all non-API functions (except main) static e03ef86559
3. 
   real-or-random commented at 5:20 pm on January 9, 2023: contributor

   Totally not opposed to this but do we really care about this in bench/tests? And if yes, do you see any way to ensure we don’t miss functions (in the future)?
4. 
   sipa commented at 6:07 pm on January 9, 2023: contributor

   Totally not opposed to this but do we really care about this in bench/tests?

   I don’t think we care either way for these, but it’s nice to be consistent.

   And if yes, do you see any way to ensure we don’t miss functions (in the future)?

   We don’t currently ensure this anywhere, but with a change like this, approaches like #1135 (depending on the direction it goes in) may be extensible to tests/bench?

5. real-or-random approved
6. 
   real-or-random commented at 6:14 pm on January 9, 2023: contributor

   Okay, agreed on both counts.

   utACK e03ef8655933d3e2b4830e7f8fe86deba820a073

7. hebasto approved
8. 
   hebasto commented at 6:43 pm on January 13, 2023: member

   ACK e03ef8655933d3e2b4830e7f8fe86deba820a073.

   On my Ubuntu 22.04 (x86_64), the resulted test and bench binaries are a bit smaller in size, except for the bench_internal, which is a bit larger.

9. real-or-random merged this on Jan 16, 2023
10. real-or-random closed this on Jan 16, 2023

    ---

11. 
    real-or-random commented at 5:54 pm on January 16, 2023: contributor

    (Fwiw, github indicated a merge conflict here (due to the renamed src/cttime_tests.c) but my local git auto-merged this cleanly without conflicts, and the merge results looks clean…)
12. sipa cross-referenced this on Jan 17, 2023 from issue Native jacobi symbol algorithm by sipa
13. sipa cross-referenced this on Jan 19, 2023 from issue Signed-digit multi-comb ecmult_gen algorithm by sipa
14. sipa cross-referenced this on Jan 19, 2023 from issue Signed-digit based ecmult_const algorithm by sipa
15. dhruv referenced this in commit 4d33046ce3 on Feb 1, 2023
16. dhruv referenced this in commit 55e7f2cf2b on Feb 2, 2023
17. stratospher referenced this in commit 647f63669e on Feb 6, 2023
18. dhruv referenced this in commit a4351c0df6 on Feb 20, 2023
19. stratospher referenced this in commit 23f825fc8b on Feb 21, 2023
20. hebasto referenced this in commit 7c0cc5d976 on Mar 7, 2023
21. dhruv referenced this in commit a5df79db12 on Mar 7, 2023
22. dhruv referenced this in commit 77b510d84c on Mar 7, 2023
23. sipa referenced this in commit 763079a3f1 on Mar 8, 2023
24. div72 referenced this in commit 945b094575 on Mar 14, 2023
25. real-or-random cross-referenced this on Mar 26, 2023 from issue Symbol visibility by real-or-random
26. vmta referenced this in commit e1120c94a1 on Jun 4, 2023
27. vmta referenced this in commit 8f03457eed on Jul 1, 2023
28. jonasnick cross-referenced this on Jul 20, 2023 from issue Upstream PRs 1160, 1193, 1169, 1190, 1192, 1194, 1196, 1195, 1170, 1172, 1200, 1199, 1203, 1201, 1206, 1078, 1209, 979, 1212, 1218, 1217, 1221, 1222 by jonasnick

Contributors
sipa real-or-random hebasto