Remove secp256k1_fe_const_b #1282
pull roconnor-blockstream wants to merge 1 commits into bitcoin-core:master from roconnor-blockstream:patch-5 changing 1 files +0 −2-
roconnor-blockstream commented at 6:12 pm on April 20, 2023: contributorIt’s last use was eliminated in #1217.
-
Remove secp256k1_fe_const_b
It's last use was eliminated in #1217.
-
real-or-random approved
-
real-or-random commented at 6:13 pm on April 20, 2023: contributorutACK d6be470ee574b58bbd222a5c14cd867fc0a7a363
-
sipa commented at 6:18 pm on April 20, 2023: contributor
0src/tests.c: In function 'ecmult_const_mult_xonly': 1src/tests.c:4501:35: error: 'secp256k1_fe_const_b' undeclared (first use in this function); did you mean 'secp256k1_ge_const_g'? 2 4501 | secp256k1_fe_add(&c, &secp256k1_fe_const_b); 3 | ^~~~~~~~~~~~~~~~~~~~ 4 | secp256k1_ge_const_g
It would appear that #1118 added another use back (which can easily be converted to
secp256k1_fe_add_int()
instead). -
real-or-random commented at 6:27 pm on April 20, 2023: contributor
0src/tests.c: In function 'ecmult_const_mult_xonly': 1src/tests.c:4501:35: error: 'secp256k1_fe_const_b' undeclared (first use in this function); did you mean 'secp256k1_ge_const_g'? 2 4501 | secp256k1_fe_add(&c, &secp256k1_fe_const_b); 3 | ^~~~~~~~~~~~~~~~~~~~ 4 | secp256k1_ge_const_g
It would appear that #1118 added another use back (which can easily be converted to
secp256k1_fe_add_int()
instead.)By the way, this shows that it’s a good idea to remove
secp256k1_fe_const_b
to make sure that noone will use it in the future. -
roconnor-blockstream closed this on Apr 20, 2023
-
sipa cross-referenced this on Apr 20, 2023 from issue Get rid of secp256k1_fe_const_b by sipa
-
real-or-random referenced this in commit f6bef03c0a on Apr 21, 2023
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-30 05:15 UTC
This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-30 05:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me