cmake: Set ENVIRONMENT property for examples on Windows #1290

pull hebasto wants to merge 3 commits into bitcoin-core:master from hebasto:230429-msvc-path changing 2 files +23 −18
  1. hebasto commented at 9:27 am on April 29, 2023: member

    This PR simplifies running examples on Windows, because the DLL must reside either in the same folder where the executable is or somewhere in PATH.

    It is an alternative to #1233.

  2. hebasto cross-referenced this on Apr 29, 2023 from issue cmake: Move runtime output artifacts to `${PROJECT_BINARY_DIR}` by hebasto
  3. hebasto force-pushed on Apr 29, 2023
  4. hebasto marked this as ready for review on Apr 29, 2023
  5. hebasto commented at 3:40 pm on April 29, 2023: member
    Rebased and undrafted.
  6. real-or-random commented at 5:36 pm on May 11, 2023: contributor
    Concept ACK
  7. real-or-random added the label build on May 11, 2023
  8. hebasto force-pushed on Jul 13, 2023
  9. hebasto commented at 4:07 pm on July 13, 2023: member
    Rebased 7a8b25034091a8ba2130712c0fe8f13bbaf15d8e -> 5a6f63a6e0d9d4168d7c893e2335fccaa99ea4e3 (pr1290.02 -> pr1290.03) due to the conflict with #1367.
  10. in examples/CMakeLists.txt:14 in 5a6f63a6e0 outdated
    17+    $<$<PLATFORM_ID:Windows>:bcrypt>
    18+  )
    19+  set(test_name ${name}_example)
    20+  add_test(NAME ${test_name} COMMAND ${target_name})
    21+  if(BUILD_SHARED_LIBS AND MSVC)
    22+    # The DLL must resides either in the same folder where the executable is
    


    real-or-random commented at 7:17 am on July 14, 2023:
    0    # The DLL must reside either in the same folder where the executable is
    
  11. real-or-random commented at 7:17 am on July 14, 2023: contributor
    utACK mod nit
  12. cmake, refactor: Use helper function instead of interface library
    This change aims to simplify the following commit.
    cef373997c
  13. cmake: Set `ENVIRONMENT` property for examples on Windows
    This change simplifies running examples on Windows, because the DLL
    must reside either in the same folder where the executable is or
    somewhere in PATH.
    116d2ab3df
  14. ci: Drop no longer needed `PATH` variable update on Windows 175db31149
  15. hebasto force-pushed on Jul 14, 2023
  16. hebasto commented at 7:46 am on July 14, 2023: member
    Updated 5a6f63a6e0d9d4168d7c893e2335fccaa99ea4e3 -> 175db31149fff4b3dc3d3dab021f289d7e98381c (pr1290.03 -> pr1290.04, diff). @real-or-random’s comment has been addressed.
  17. real-or-random approved
  18. real-or-random commented at 7:46 am on July 14, 2023: contributor
    utACK 175db31149fff4b3dc3d3dab021f289d7e98381c
  19. real-or-random commented at 9:52 pm on July 20, 2023: contributor
    @theuni Would you like to review this?
  20. real-or-random merged this on Aug 3, 2023
  21. real-or-random closed this on Aug 3, 2023

  22. real-or-random commented at 1:15 pm on August 3, 2023: contributor
    Merging, but happy to see any post-merge review.
  23. hebasto deleted the branch on Aug 3, 2023
  24. hebasto cross-referenced this on Aug 3, 2023 from issue ci: Run "Windows (VS 2022)" job on GitHub Actions by hebasto

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 14:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me