cmake: Use SECP256K1_COVERAGE option instead of CMAKE_BUILD_TYPE=Coverage #1291

pull hebasto wants to merge 3 commits into bitcoin-core:master from hebasto:230429-coverage changing 4 files +112 −69
  1. hebasto commented at 10:42 pm on April 29, 2023: member

    Providing -DCMAKE_BUILD_TYPE=Coverage does not work for multi-config generators.

    For example:

    0$ cmake -S . -B ../build -G "Ninja Multi-Config"
    1$ cmake --build ../build --config Coverage
    

    still builds the tests binary.

    This PR:

    • fixes this issue
    • is based on the in-person discussion during the recent CoreDev
    • is an alternative to #1251

    The last commit addresses that comment.

  2. hebasto commented at 12:36 pm on June 1, 2023: member
    Friendly ping @theuni :)
  3. theuni commented at 7:12 pm on June 23, 2023: contributor

    Sorry for the missed ping.

    Concept ACK as discussed in Dublin. Will review next week.

  4. real-or-random added the label build on Jun 26, 2023
  5. cmake: Add `ProcessConfigurations.cmake` module 014e063a10
  6. cmake: Use `SECP256K1_COVERAGE` instead of `CMAKE_BUILD_TYPE=Coverage`
    This change fixes coverage-enabled builds for multi-configuration
    generators, e.g., "Ninja Multi-Config".
    4b3bd66540
  7. autotools, docs: Adjust help string for `--enable-coverage` option 94dd0c0b99
  8. hebasto force-pushed on Jul 2, 2023
  9. hebasto commented at 3:56 pm on July 2, 2023: member
    Rebased.
  10. hebasto referenced this in commit 92e4391161 on Sep 13, 2023
  11. hebasto marked this as a draft on May 7, 2024
  12. hebasto commented at 3:15 pm on August 18, 2024: member
    Closing in favour of #1592.
  13. hebasto closed this on Aug 18, 2024


hebasto theuni

Labels
build


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-30 03:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me