Revert “Remove unused scratch space from API” #1311

pull jonasnick wants to merge 1 commits into bitcoin-core:master from jonasnick:revert-scratch changing 3 files +38 −4
  1. jonasnick commented at 3:07 pm on May 12, 2023: contributor

    This reverts commit 712e7f8722eba5dec2bc6b37d75aadeb6f6e633b.

    Removing the scratch space from the API may break bindings to the library.

  2. Revert "Remove unused scratch space from API"
    This reverts commit 712e7f8722eba5dec2bc6b37d75aadeb6f6e633b.
    3ad1027a40
  3. real-or-random approved
  4. real-or-random commented at 3:10 pm on May 12, 2023: contributor
    ACK 3ad1027a4034da674aeee2a92dfba69b347bbe91
  5. sipa commented at 3:13 pm on May 12, 2023: contributor

    ACK 3ad1027a4034da674aeee2a92dfba69b347bbe91

    When reviewing the scratch space removal, my thinking was that it wasn’t a particularly impactful while technically an API breaking change. However, language bindings exist which expose this API, and would fail to link if it is removed. Combining with the fact that we’re in a position that suggests a point release, it’s better if this isn’t part of it.

    We should re-revert it (if still considered appropriate) before 0.4.0.

  6. sipa merged this on May 12, 2023
  7. sipa closed this on May 12, 2023

  8. hebasto referenced this in commit 49c52ea2b1 on May 13, 2023
  9. vmta referenced this in commit e1120c94a1 on Jun 4, 2023
  10. sipa referenced this in commit 901336eee7 on Jun 21, 2023
  11. vmta referenced this in commit 8f03457eed on Jul 1, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-23 08:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me