Verify the result of GMP modular inverse using non-GMP code #270

pull sipa wants to merge 1 commits into bitcoin-core:master from sipa:gmpcheck changing 2 files +13 −1
  1. sipa commented at 3:23 pm on July 9, 2015: contributor
    This hides potential GMP bugs from the verification.
  2. Verify the result of GMP modular inverse using non-GMP code 36b305a82b
  3. gmaxwell commented at 2:30 am on July 10, 2015: contributor

    Oh no! A ~1/10th of 1% verify slowdown measured here. :)

    Looks good to me, and I verified that if I break GMP that it detects it for each of the cases. Spun it up in some more testsing; just for good measure.

  4. gmaxwell commented at 11:32 pm on July 12, 2015: contributor

    ACK.

    We had some discussion in IRC about a fancier way to do fatal error handling which might be useful in the future.

  5. sipa merged this on Jul 14, 2015
  6. sipa closed this on Jul 14, 2015

  7. sipa referenced this in commit 4ab8990c52 on Jul 14, 2015


sipa gmaxwell


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-30 07:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me