Bad callback logic #300

issue theuni openend this issue on September 1, 2015
  1. theuni commented at 6:05 pm on September 1, 2015: contributor

    Given that ARG_CHECK is defined as:

    0#define ARG_CHECK(cond) do { \
    1    if (EXPECT(!(cond), 0)) { \
    2        ctx->illegal_callback.fn(#cond, ctx->illegal_callback.data); \
    3        return 0; \
    4    } \
    5} while(0)
    

    These checks (17 of ’em from a quick grep) make no sense and are doomed to explode:

    0ARG_CHECK(ctx != NULL);
    
  2. gmaxwell commented at 6:14 pm on September 1, 2015: contributor
    Haha.
  3. theuni cross-referenced this on Sep 1, 2015 from issue bugfix: don't blow up on "ARG_CHECK(ctx != NULL)" by theuni
  4. sipa commented at 7:06 pm on September 1, 2015: contributor
    Good catch!
  5. theuni cross-referenced this on Sep 3, 2015 from issue remove unused assignment by theuni
  6. gmaxwell added this to the milestone initial release on Sep 17, 2015
  7. sipa commented at 11:07 pm on September 29, 2015: contributor
    Fixed by #301
  8. sipa closed this on Sep 29, 2015


theuni gmaxwell sipa

Milestone
stable release (1.0.0-rc.1)


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-30 11:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me