The use of static makes this somewhat redundant currently, though if we later have multiple compilation units it will be needed.
This also sets the dllexport needed for shared libraries on win32.
Use explicit symbol visibility. #312
pull gmaxwell wants to merge 2 commits into bitcoin-core:master from bitcoin-core:explicit_export changing 9 files +62 −36-
gmaxwell commented at 8:00 PM on September 20, 2015: contributor
-
c2ef56a116
Include public module headers when compiling modules.
Also fix the nullness requirements for schnorr nonce-pair generation.
-
ca7cb4c7d8
Use explicit symbol visibility.
The use of static makes this somewhat redundant currently, though if we later have multiple compilation units it will be needed. This also sets the dllexport needed for shared libraries on win32.
-
-
sipa commented at 7:05 PM on September 21, 2015: contributor
Just to get this straight: -fvisibiblity changes the visibility across library boundaries, while static changes the visibility across module boundaries?
-
-
theuni commented at 8:08 PM on September 21, 2015: contributor
Looks good to me. This replaces #223, but I like this approach better.
Only thing I'm iffy about is the win32+static case, where we won't want to set dllexport. libtool automatically sets -DDLL_EXPORT when building for a dll, I think we could take advantage of that like:
# if defined(SECP256K1_BUILD) && defined(DLL_EXPORT) # define SECP256K1_EXPORT __declspec(dllexport) # else -
gmaxwell commented at 8:11 PM on September 21, 2015: contributor
@sipa Yes. static, as a side-effect, makes things invisible across a library boundary. But it does so by making it invisible across module boundaries. Right now, since the library is a single C file, static is sufficient. But win32 wants explicit visibility for libraries in all cases (either via a symbol file, or via the dll annotations this also adds), and we might want multiple modules in the future. @theuni Probably the most interesting/challenges cases for DLL building are when people are using an alternative build system, though I suppose they could just set DLL_EXPORT too. What does setting dllexport on a win32 static do? I don't think I've ever seen any complaints from setting it there. If it's harmless-- might as well set it.
-
-
-
theuni commented at 9:09 PM on September 21, 2015: contributor
whoops, s/WIN32/_WIN32/.
WIN32 isn't picked up by my mingw install.
-
- gmaxwell closed this on Sep 21, 2015
- gmaxwell deleted the branch on Sep 21, 2015
- gmaxwell cross-referenced this on Sep 21, 2015 from issue Use explicit symbol visibility. by gmaxwell
