Implement secp256k1_ecdsa_signature_serialize and int secp256k1_ecdsa_signature_parse #333

issue rustyrussell openend this issue on October 11, 2015
  1. rustyrussell commented at 9:22 am on October 11, 2015: contributor

    Non-DER versions, which just fill in 64 bits in some canonical order.

    Alternately: make the opaque structure a canonical order.

  2. sipa commented at 12:57 pm on October 11, 2015: contributor
    See my laxder branch, it also adds those. I’ll PR when I either decide to split it off from the DER rework, or tests for that are finished.
  3. rustyrussell commented at 10:50 pm on October 11, 2015: contributor

    Yep, looks good! Please document the serialize format (at a glance, it’s 32 byte unsigned BE r value followed by 32 byte unsigned BE s value).

    I’d still like a “is_normalized” or “is_canonical” for the s-value test BTW, but I can implement my own with these.

  4. sipa commented at 5:00 pm on October 17, 2015: contributor
    Working on those!
  5. sipa commented at 5:22 am on November 28, 2016: contributor
    Fixed by #334.
  6. sipa closed this on Nov 28, 2016


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-25 09:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me