tests and bench do not need linking with secp256k1.o #39

1. 
   sipa commented at 0:58 am on June 23, 2014: contributor

   As both tests.c and bench.c include the the _impl.h h headers, they should be self-contained, and not need linking with libsecp256k1.la.

   They do need the assembly code though, if it is used.

   Ping @theuni?

2. 
   theuni commented at 4:44 pm on June 23, 2014: contributor

   @sipa now that we have automake and can select the proper input files based on configure, would you be interested in moving the _impl.h -> _impl.c, then building the necessary objects based on make directives, rather than include magic?

   That would help in this case, as well as in modularizing a bit. As an easy-to-see win, the test program could then run against all implementations at once.

   If that’s not a goal, then we can just take the shortcut here and link in the asm object in that case.

3. 
   sipa commented at 4:58 pm on June 23, 2014: contributor

   @theuni That breaks the compiler’s ability to inline, which we’re strongly relying upon. I haven’t tested the performance hit, so I may be overestimating it.
4. 
   theuni commented at 6:47 pm on June 23, 2014: contributor

   @sipa Understood. I’d like to discuss that, but this issue isn’t the place for it. I’ll PR the simple fix for this one.
5. 
   sipa commented at 0:56 am on August 28, 2014: contributor

   Fixed by #55.
6. sipa closed this on Aug 28, 2014

   ---

7. real-or-random referenced this in commit 6532fa0a96 on Mar 5, 2019

Contributors
sipa theuni