unit test failure in Core PR 15796 #610

1. 
   instagibbs commented at 9:34 pm on April 12, 2019: none

    0make[6]: Entering directory '/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src/secp256k1'
    1./build-aux/test-driver: line 107: 26441 Aborted                 (core dumped) "$@" > $log_file 2>&1
    2FAIL: tests
    3PASS: exhaustive_tests
    4========================================
    5   libsecp256k1 0.1: ./test-suite.log
    6========================================
    7
    8# TOTAL: 2
    9# PASS:  1
   10# SKIP:  0
   11# XFAIL: 0
   12# FAIL:  1
   13# XPASS: 0
   14# ERROR: 0
   15
   16.. contents:: :depth: 2
   17
   18FAIL: tests
   19===========
   20
   21src/tests.c:405: test condition failed: ((~x[m][shift]) << (64 - (1 << usebits))) == 0
   22test count = 64
   23random seed = 54d904804b5e0db448021441be754c10
   24FAIL tests (exit status: 134)
   25
   26============================================================================
   27Testsuite summary for libsecp256k1 0.1
   28============================================================================
   29# TOTAL: 2
   30# PASS:  1
   31# SKIP:  0
   32# XFAIL: 0
   33# FAIL:  1
   34# XPASS: 0
   35# ERROR: 0
   36============================================================================
   37See ./test-suite.log
   38============================================================================
   39make[6]: *** [test-suite.log] Error 1
   40Makefile:1213: recipe for target 'test-suite.log' failed
   41make[6]: Leaving directory '/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src/secp256k1'
   42make[5]: *** [check-TESTS] Error 2
   43Makefile:1319: recipe for target 'check-TESTS' failed
   44make[5]: Leaving directory '/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src/secp256k1'
   45make[4]: *** [check-am] Error 2
   46Makefile:1532: recipe for target 'check-am' failed
   47make[4]: Leaving directory '/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src/secp256k1'
   48Makefile:13330: recipe for target 'check-local' failed
   49make[3]: *** [check-local] Error 2
   50make[3]: Leaving directory '/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src'
   51make[2]: *** [check-am] Error 2
   52Makefile:13078: recipe for target 'check-am' failed
   53make[2]: Leaving directory '/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src'
   54make[1]: *** [check-recursive] Error 1
   55Makefile:12766: recipe for target 'check-recursive' failed
   56make[1]: Leaving directory '/home/travis/build/bitcoin/bitcoin/build/bitcoin-x86_64-unknown-linux-gnu/src'
   57make: *** [check-recursive] Error 1
   58Makefile:775: recipe for target 'check-recursive' failed
   

2. 
   instagibbs commented at 9:34 pm on April 12, 2019: none

   Probably random but felt best to report since I’ve never seen one in a long time.
3. instagibbs cross-referenced this on Apr 12, 2019 from issue CReserveKey should not allow passive key re-use, debug assert in destructor by instagibbs
4. 
   MarcoFalke commented at 9:39 pm on April 12, 2019: none

   Last time I reproduced them they were non-deterministic even with the same seed used
5. 
   sipa commented at 9:41 pm on April 12, 2019: contributor

   The randomness tests are known to fail in a small number of cases (there is an old PR about this, #367 but iirc it didn’t actually improve things). @MarcoFalke It should be deterministic if the source code, seed, and test count are identical.
6. 
   gmaxwell commented at 9:41 pm on April 12, 2019: contributor

   @MarcoFalke Can you clarify what you mean? Unless there is a serious bug there should be no source of nondeterminism in the tests (other than the seed)
7. 
   instagibbs commented at 9:44 pm on April 12, 2019: none

   @MarcoFalke is the seed dumped anywhere?
8. 
   sipa commented at 9:49 pm on April 12, 2019: contributor

   @instagibbs From your output:

   0test count = 64
   1random seed = 54d904804b5e0db448021441be754c10
   

9. 
   jonasnick commented at 9:20 am on April 13, 2019: contributor

   It can be reproduced:

   0$ ./tests 1 54d904804b5e0db448021441be754c10
   1test count = 3
   2random seed = 54d904804b5e0db448021441be754c10
   3src/tests.c:450: test condition failed: ((~x[m][shift]) << (64 - (1 << usebits))) == 0
   

10. 
    instagibbs commented at 12:11 pm on April 13, 2019: none

    Good to know, closing unless Marco has a non-reproducible failure with seed
11. instagibbs closed this on Apr 13, 2019

    ---

12. MarcoFalke cross-referenced this on Jul 13, 2021 from issue Make m_mempool optional in CChainState by jamesob
13. real-or-random cross-referenced this on Jul 17, 2023 from issue subtree: update libsecp256k1 to latest master by fanquake

Contributors
instagibbs MarcoFalke sipa gmaxwell jonasnick