Fix a nit in the recovery tests #657

pull elichai wants to merge 1 commits into bitcoin-core:master from elichai:patch-1 changing 1 files +1 −1
  1. elichai commented at 2:08 pm on August 21, 2019: contributor

    this signature is only valid under recid 1 not 0.

    Source: https://github.com/bitcoin-core/secp256k1/blob/master/src/modules/recovery/tests_impl.h#L247 (it passes only when the sig is parsed with recid 1)

  2. Fix a nit in the recovery tests b64a2e2597
  3. real-or-random approved
  4. real-or-random commented at 2:14 pm on August 21, 2019: contributor
  5. jonasnick approved
  6. jonasnick commented at 8:47 am on August 22, 2019: contributor
    ACK b64a2e2597b66b57e23f3cb34f9c88809e34d93f read the code
  7. jonasnick referenced this in commit e729cc7f5a on Aug 22, 2019
  8. jonasnick merged this on Aug 22, 2019
  9. jonasnick closed this on Aug 22, 2019

  10. elichai deleted the branch on Aug 22, 2019
  11. sipa cross-referenced this on Jun 9, 2020 from issue Update libsecp256k1 subtree by sipa
  12. fanquake referenced this in commit 8c97780db8 on Jun 13, 2020
  13. sidhujag referenced this in commit 8a3a072968 on Jun 13, 2020
  14. ComputerCraftr referenced this in commit b98f1c6e6c on Jun 16, 2020
  15. UdjinM6 referenced this in commit 9d36ba6570 on Aug 10, 2021
  16. 5tefan referenced this in commit 8ded2caa74 on Aug 12, 2021
  17. gades referenced this in commit d855cc511d on May 8, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-22 23:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me