Check if variable=yes instead of if var is set in travis.sh #782

1. 
   elichai commented at 9:21 am on July 30, 2020: contributor

   Right now travis.sh checks if VALGRIND and CTIMETEST are set or not, but in travis.yml we explictly set them to yes so I think it’s more intuitive to check if they’re equal to yes such that setting CTIMETEST=no(or anything other than “yes”) will disable the test.

   pointed out by @real-or-random here: #696 (review)

2. elichai renamed this:
   travis.sh check if variable=yes instead of if var is set
   Check if variable=yes instead of if var is set in travis.sh
   on Jul 30, 2020
3. 
   real-or-random commented at 8:45 am on August 3, 2020: contributor

   I think that’s an improvement but then we should do this for BENCH too.
4. Change travis.sh to check if variables are equal to yes instead of

   not-empty.
   Before this, setting `VALGRIND=wat` was considered as true, and to make it
   evaluate as false you had to unset the variable `VALGRIND=` but not it
   checks if `VALGRIND=yes` and if it's not `yes` then it's evaluated to
   false

   ef37761fee
5. elichai force-pushed on Aug 3, 2020
6. 
   real-or-random commented at 10:55 am on August 7, 2020: contributor

   Should we change the corresponding flags to no then, e.g., here? https://github.com/bitcoin-core/secp256k1/blob/master/.travis.yml#L34
7. 
   elichai commented at 11:13 am on August 7, 2020: contributor

   We could, but unlike BIGNUM=no which passes to configure and it will check that it contains something valid, here we only check if it’s yes or not, we don’t check if it’s no or something else. but maybe it’s still worth it for consistency and readability
8. 
   real-or-random commented at 12:09 pm on August 7, 2020: contributor

   but maybe it’s still worth it for consistency and readability

   That was my thought.

9. 
   real-or-random commented at 11:31 am on September 14, 2020: contributor

   @elichai do you want to make that change?
10. Modify .travis.yml to explictly pass no in env vars instead of setting to nothing 34debf7a6d
11. 
    elichai commented at 3:02 pm on September 14, 2020: contributor

    @elichai do you want to make that change?

    Sorry, forgot about this. pushed now.

12. 
    real-or-random commented at 8:57 am on September 15, 2020: contributor

    ACK 34debf7a6d36bbd9a52e68e079ddfc446faf5bef

    Would be nice to get a second ACK, then we can merge this before doing the travis changes of #813

13. real-or-random approved
14. jonasnick approved
15. 
    jonasnick commented at 5:44 pm on September 15, 2020: contributor

    ACK 34debf7a6d36bbd9a52e68e079ddfc446faf5bef
16. jonasnick merged this on Sep 15, 2020
17. jonasnick closed this on Sep 15, 2020

    ---

18. elichai deleted the branch on Sep 16, 2020
19. jasonbcox referenced this in commit 46c5de3c85 on Sep 29, 2020
20. deadalnix referenced this in commit 665bcdd2e4 on Sep 30, 2020

Contributors
elichai real-or-random jonasnick