add ECMULT_GEN_PREC_BITS to basic_config.h #916

pull voisine wants to merge 1 commits into bitcoin-core:master from voisine:patch-1 changing 1 files +1 −0
  1. voisine commented at 6:37 pm on April 10, 2021: contributor
    set ECMULT_GEN_PREC_BITS to the “auto” value of 4 in basic_config.h, so libsecp can be used without autoconf
  2. add ECMULT_GEN_PREC_BITS to basic_config.h
    set ECMULT_GEN_PREC_BITS to the "auto" value of 4 in basic_config.h, so libsecp can be used without autoconf
    fe9469feb0
  3. real-or-random commented at 1:58 pm on April 11, 2021: contributor

    Thanks for the PR, this is indeed a bug! However, fixing it requires some more cleanup (see CI failures).

    I’m currently playing around with some options. I should have something ready by tomorrow.

  4. real-or-random commented at 2:02 pm on April 11, 2021: contributor

    By the way, how do you use this library without autoconf? Do you simply #include it or do you build it and then link it? In either case I’d we interested in the exact method, e.g.: How do you define your config? Do you include basic-config.h? What’s the command line?

    This could help us towards #622.

  5. voisine commented at 5:17 pm on April 11, 2021: contributor
    Thank you. Currently I just #include basic_config.h and then the appropriate libsecp implementations, but I eventually plan to add the source files to an external build system other than “make”
  6. voisine commented at 5:26 pm on April 11, 2021: contributor
    Specifically I want to be able to build using Xcode on a clean OS X install without installing additional build tools like autoconf.
  7. real-or-random cross-referenced this on Apr 12, 2021 from issue Clean up configuration in gen_context by real-or-random
  8. jonasnick commented at 5:00 pm on April 19, 2021: contributor
    Superseded by #918 (merged)
  9. jonasnick closed this on Apr 19, 2021

  10. voisine commented at 10:21 pm on April 19, 2021: contributor
    Excellent. My commit even managed to survive into the final merge. Thank you.
  11. voisine deleted the branch on Dec 1, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-30 03:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me