Removed 3 gotos. Their style makes it hard for readers to trace, and maintainers can make mistakes too easily.
(Also included is fix to configure to allow homebrew, another MacOSX package manager, to provide the needed libraries. Homebrew uses /usr/local rather than /opt/local which is the domain of macports.)
From a control flow complexity perspective multiple returns and goto are equivilent; and I’ve seen them lead to the same bugs.
This can be done here since it just recently dropped support for number types that need deallocation, though it does now have a risk of gaining a memory leak if they’re reintroduced (“oh well”). (And probably should; the error goto style is ideomatic C where deallocation needs to happen conditional on error, and not generally elsewhere).
I have a mild preference for restructuing so that the return at the bottom is a failure, swapping the not on the last branch and making it return 1; just because the preference is for futuer bugs to return failure; but thats probably nitpicking pieter can comment.
-1
It makes control flow easier to follow. “early return” can just as easily lead to bugs, so that is invalid logic as presented. goto error handling in C is extremely common and works just fine.
