build: Add a check that Valgrind actually supports a host platform #1027

pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:211203-riscv changing 1 files +7 −1
  1. hebasto commented at 1:21 pm on December 3, 2021: member

    This PR adds a check that Valgrind actually supports a host platform.

    On master (49f608de474a89e5c742830c8ff5ac8978b5796a):

    0$ ./autogen.sh &> /dev/null && ./configure -q --host=riscv64-linux-gnu 2>&1 | grep valgrind
    1  valgrind                = yes
    

    With this PR:

    0$ ./autogen.sh &> /dev/null && ./configure -q --host=riscv64-linux-gnu 2>&1 | grep valgrind
    1  valgrind                = no
    

    Closes #1023.

  2. real-or-random commented at 2:00 pm on December 3, 2021: contributor

    Nice, I thought that will be much more diffcult.

    Concept ACK

    nit: s/valgring/valgrind

  3. hebasto renamed this:
    build: Add a check that Valgring actually supports a host platform
    build: Add a check that Valgrind actually supports a host platform
    on Dec 3, 2021
  4. build: Add a check that Valgrind actually supports a host platform 7c7ce872a5
  5. hebasto force-pushed on Dec 3, 2021
  6. hebasto commented at 3:34 pm on December 3, 2021: member

    @real-or-random

    nit: s/valgring/valgrind

    Thanks! Fixed.

  7. sipa commented at 10:36 pm on December 3, 2021: contributor
    utACK 7c7ce872a53f386f7c6a3a8ea04442840902193b
  8. real-or-random commented at 10:34 am on December 5, 2021: contributor

    utACK 7c7ce872a53f386f7c6a3a8ea04442840902193b

    valgrind.h (included by memcheck.h) defines NVALGRIND if platform detection fails: https://sourceware.org/git/?p=valgrind.git;a=blob;f=include/valgrind.h.in;h=aa0b431256e14da602064c1052c2c5fb5f7f88d4;hb=HEAD#l172

    edit: I checked that valgrind support still is detected on my machine.

  9. real-or-random merged this on Dec 5, 2021
  10. real-or-random closed this on Dec 5, 2021

  11. hebasto deleted the branch on Dec 5, 2021
  12. sipa referenced this in commit 86dbc4d075 on Dec 15, 2021
  13. sipa cross-referenced this on Dec 15, 2021 from issue Update libsecp256k1 subtree to current master by sipa
  14. jonasnick cross-referenced this on Jan 2, 2022 from issue Sync Upstream by jonasnick
  15. real-or-random referenced this in commit 21e2d65b79 on Jan 5, 2022
  16. gwillen referenced this in commit 35d6112a72 on May 25, 2022
  17. janus referenced this in commit 879a9a27b9 on Jul 10, 2022
  18. patricklodder referenced this in commit 21badcf9d2 on Jul 25, 2022
  19. patricklodder referenced this in commit 03002a9013 on Jul 28, 2022
  20. backpacker69 referenced this in commit 77186f4a04 on Jan 18, 2023
  21. hebasto cross-referenced this on Apr 11, 2023 from issue build: Make `SECP_VALGRIND_CHECK` preserve `CPPFLAGS` by hebasto
  22. real-or-random referenced this in commit 2e035af251 on Apr 20, 2023
  23. str4d referenced this in commit 6de4698bf9 on Apr 21, 2023
  24. vmta referenced this in commit e1120c94a1 on Jun 4, 2023
  25. vmta referenced this in commit 8f03457eed on Jul 1, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-23 00:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me