ci: Attempt to make macOS builds more reliable #1072

pull real-or-random wants to merge 1 commits into bitcoin-core:master from real-or-random:202202-brew-reinstall changing 1 files +3 −1

real-or-random commented at 9:55 AM on February 4, 2022: contributor
The macOS CI tasks often error fail when doing brew update with git fetch errors:
```
remote: fatal: packfile /data/repositories/b/nw/b6/07/5c/123272362/network.git/objects/pack/pack-2139bd07361b62a358e380a0e7d58ec35593d191.pack cannot be accessed
fatal: protocol error: bad pack header
Error: Fetching /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core failed!
```
Superficially this seems to be a problem on the GitHub server because the message shows a "remote" error. But it seems we're the only one in the world running into this specific issue when doing brew update, so it's more likely that the something else is the culprit, and this error message is just a symptom.

This commit replaces brew update with a complete reinstallation of brew. This is essentially a shot in the dark but it's worth a try, and I doubt it's significantly more expensive. If that won't work, we may consider simply retrying brew update a few times.

ci: Attempt to make macOS builds more reliable

The macOS CI tasks often error fail when doing `brew update` with
git fetch errors:
```
remote: fatal: packfile /data/repositories/b/nw/b6/07/5c/123272362/network.git/objects/pack/pack-2139bd07361b62a358e380a0e7d58ec35593d191.pack cannot be accessed
fatal: protocol error: bad pack header
Error: Fetching /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core failed!
```
Superficially this seems to be a problem on the GitHub server because
the message shows a "remote" error. But it seems we're the only one in
the world running into this specific issue when doing `brew update`, so
it's more likely that the something else is the culprit, and this error
message is just a symptom.

This commit replaces `brew update` with a complete reinstallation of
brew. This is essentially a shot in the dark but it's worth a try, and
I doubt it's significantly more expensive. If that won't work, we may
consider simply retrying `brew update` a few times.

d9396a56da

real-or-random commented at 2:30 PM on February 4, 2022: contributor

Ok CI passed on first try, and this adds < 10 seconds to the macOS tasks. Let's re-run it. :P

edit: ok, let's try a third a last time.
real-or-random commented at 7:45 AM on February 5, 2022: contributor

Ok, all three runs pass. I think it's worth the try and merge it.
jonasnick commented at 7:22 PM on February 6, 2022: contributor

ACK d9396a56da13df97827e193f636a7593fb4d7864

See issue https://github.com/cirruslabs/osx-images/issues/41#issuecomment-1025009317 for more context.
jonasnick merged this on Feb 6, 2022
jonasnick closed this on Feb 6, 2022
real-or-random commented at 8:34 AM on February 7, 2022: contributor

Great, now we don't even get proper error messages any more: https://cirrus-ci.com/task/6275416297046016?logs=brew_valgrind_pre#L126

I think we should use the script that Core uses: https://github.com/bitcoin/bitcoin/tree/master/ci/retry
real-or-random cross-referenced this on Feb 8, 2022 from issue ci: Retry brew update a few times to avoid random failures by real-or-random
fanquake referenced this in commit 8f8631d826 on Mar 17, 2022
fanquake referenced this in commit 4bb1d7e62a on Mar 17, 2022
fanquake referenced this in commit 465d05253a on Mar 30, 2022
jonasnick cross-referenced this on Mar 30, 2022 from issue Upstream PRs 1064, 1049, 899, 1068, 1072, 1069, 1074, 1026, 1033, 748, 1079, 1088, 1090, 731, 1089, 995, 1094, 1093 by jonasnick
real-or-random referenced this in commit 6c0aecf72b on Apr 1, 2022
fanquake referenced this in commit afb7a6fe06 on Apr 6, 2022
gwillen referenced this in commit 35d6112a72 on May 25, 2022
patricklodder referenced this in commit 21badcf9d2 on Jul 25, 2022
patricklodder referenced this in commit 03002a9013 on Jul 28, 2022
janus referenced this in commit 3a0652a777 on Aug 4, 2022
str4d referenced this in commit 522190d5c3 on Apr 21, 2023
vmta referenced this in commit e1120c94a1 on Jun 4, 2023
vmta referenced this in commit 8f03457eed on Jul 1, 2023

Contributors

real-or-random

jonasnick

Linked (view graph)

#1074 ci: Retry brew update a few times to avoid random failures