configure: Remove redundant pkg-config code

real-or-random commented at 3:44 pm on March 16, 2022: contributor

This removes code that detects the pkg-config tool. We used this back in the days when we had dependencies. ;) It can always be brought back if we’ll need it in the future.

Note that we still deliver a .pc file for this library, and there is code in Makefile.am to install it. But this does not require the pkg-config tool; only consumers of the .pc file will need it. This can be verified by running make install (maybe after mkdir /tmp/pre and ./configure --prefix=/tmp/pre and checking that the .pc file is installed correctly.

This removes code that detects the pkg-config tool. We used this
back in the days when we had dependencies. ;) It can always be brought
back if we'll need it in the future.

Note that we still deliver a .pc file for this library, and there is
code in Makefile.am to install it. But this does not require the
pkg-config tool; only consumers of the .pc file will need it. This can
be verified by running `make install` (maybe after `mkdir /tmp/pre` and
`./configure --prefix=/tmp/pre` and checking that the .pc file is
installed correctly.

21b2ebaf74

real-or-random force-pushed on Mar 16, 2022

fanquake commented at 3:58 pm on March 16, 2022: member

Nice. Concept ACK

theuni commented at 0:20 am on March 17, 2022: contributor

ACK 21b2ebaf74222017f85123deb6f30a33c7678513.

Nice to not have dependencies :)

theuni commented at 0:34 am on March 17, 2022: contributor

Also note that removal may allow Core to get rid of this hack: https://github.com/bitcoin/bitcoin/blob/d6cb4e8ff0d0772fd549240c21cf08e5213259be/configure.ac#L1939-L1945

fanquake approved

fanquake commented at 10:16 am on March 17, 2022: member

ACK 21b2ebaf74222017f85123deb6f30a33c7678513

Also note that removal may allow Core to get rid of this hack:

I’ve pushed changes up into https://github.com/bitcoin/bitcoin/pull/24341 so we can have a look.

fanquake cross-referenced this on Mar 17, 2022 from issue build: remove some no-longer-needed var unexporting from configure by fanquake

real-or-random merged this on Mar 17, 2022

real-or-random closed this on Mar 17, 2022

fanquake referenced this in commit 4bb1d7e62a on Mar 17, 2022

fanquake referenced this in commit 465d05253a on Mar 30, 2022

jonasnick cross-referenced this on Mar 30, 2022 from issue Upstream PRs 1064, 1049, 899, 1068, 1072, 1069, 1074, 1026, 1033, 748, 1079, 1088, 1090, 731, 1089, 995, 1094, 1093 by jonasnick

real-or-random referenced this in commit 6c0aecf72b on Apr 1, 2022

fanquake referenced this in commit afb7a6fe06 on Apr 6, 2022

fanquake cross-referenced this on Apr 6, 2022 from issue Update libsecp256k1 subtree to current master by fanquake

fanquake referenced this in commit 747cdf1d65 on Apr 9, 2022

gwillen referenced this in commit 35d6112a72 on May 25, 2022

real-or-random cross-referenced this on Jul 20, 2022 from issue Bitcoin Core `configure` fails after #1084 was merged by dhruv

fanquake cross-referenced this on Jul 21, 2022 from issue Revert "build: remove some no-longer-needed var unexporting from conf… by hebasto

real-or-random referenced this in commit 7597a3d5e7 on Jul 21, 2022

real-or-random cross-referenced this on Jul 21, 2022 from issue configure: Remove pkgconfig macros again (reintroduced by mismerge) by real-or-random

real-or-random referenced this in commit cabe085bb4 on Jul 21, 2022

real-or-random referenced this in commit 9f8a13dc8e on Jul 21, 2022

patricklodder referenced this in commit 21badcf9d2 on Jul 25, 2022

patricklodder referenced this in commit 03002a9013 on Jul 28, 2022

janus referenced this in commit 3a0652a777 on Aug 4, 2022

str4d referenced this in commit 522190d5c3 on Apr 21, 2023

dderjoel referenced this in commit 3768744290 on May 23, 2023

vmta referenced this in commit e1120c94a1 on Jun 4, 2023

vmta referenced this in commit 8f03457eed on Jul 1, 2023

configure: Remove redundant pkg-config code #1090