ecmult_gen: Skip RNG when creating blinding if no seed is available #1120

pull real-or-random wants to merge 3 commits into bitcoin-core:master from real-or-random:202207-ecmult-gen-skip-rng changing 1 files +9 −8
  1. real-or-random commented at 5:16 pm on July 5, 2022: contributor

    Running the RNG is pointless if no seed is available because the key will be fixed. The computation just wastes time.

    Previously, users could avoid this computation at least by asking for a context without signing capabilities. But since 3b0c218 we always build an ecmult_gen context, ignoring the context flags. Moreover, users could never avoid this pointless computation when asking for the creation of a signing context.

    This fixes one item in #1065.

  2. real-or-random cross-referenced this on Jul 5, 2022 from issue Context randomization tracking issue by apoelstra
  3. real-or-random cross-referenced this on Jul 5, 2022 from issue Further changes after making tables static by real-or-random
  4. ecmult_gen: Skip RNG when creating blinding if no seed is available
    Running the RNG is pointless if no seed is available because the key
    will be fixed. The computation just wastes time.
    
    Previously, users could avoid this computation at least by asking for
    a context without signing capabilities. But since 3b0c218 we always
    build an ecmult_gen context, ignoring the context flags. Moreover,
    users could never avoid this pointless computation when asking for
    the creation of a signing context.
    4cc0b1b669
  5. ecmult_gen: Simplify code (no observable change) 7a86955800
  6. ecmult_gen: Improve comments about projective blinding
    Whenever I read this code, I first think that rescaling ctx->initial is
    a dead store because we overwrite it later with gb. But that's wrong.
    The rescaling blinds the computation of gb and affects its result.
    55f8bc99dc
  7. real-or-random force-pushed on Jul 5, 2022
  8. apoelstra approved
  9. apoelstra commented at 6:04 pm on July 5, 2022: contributor
    ACK 55f8bc99dce8846e0da99b92e52353c8cf893287
  10. sipa commented at 4:02 pm on July 7, 2022: contributor
    ACK 55f8bc99dce8846e0da99b92e52353c8cf893287
  11. real-or-random merged this on Jul 7, 2022
  12. real-or-random closed this on Jul 7, 2022

  13. real-or-random cross-referenced this on Jul 18, 2022 from issue API cleanup with respect to contexts by real-or-random
  14. dhruv referenced this in commit 2dfd7005d9 on Jul 19, 2022
  15. dhruv referenced this in commit 21e2acb595 on Jul 20, 2022
  16. dhruv referenced this in commit f70e7d8108 on Jul 20, 2022
  17. dhruv referenced this in commit a1ac8e1b7f on Jul 20, 2022
  18. hebasto referenced this in commit 07695f6c2d on Jul 21, 2022
  19. dhruv referenced this in commit e5166959a4 on Jul 21, 2022
  20. dhruv referenced this in commit 726cbfe06c on Jul 21, 2022
  21. dhruv referenced this in commit c354ccd3e6 on Jul 21, 2022
  22. dhruv referenced this in commit 296cb3807d on Jul 21, 2022
  23. dhruv referenced this in commit a7efff1c21 on Jul 22, 2022
  24. dhruv referenced this in commit 5667aa958a on Aug 12, 2022
  25. dhruv referenced this in commit 06823cfe29 on Aug 24, 2022
  26. dhruv referenced this in commit 6eca30d4bd on Sep 2, 2022
  27. dhruv referenced this in commit c3ed192dda on Sep 2, 2022
  28. dhruv referenced this in commit 89ebab0601 on Oct 1, 2022
  29. dhruv referenced this in commit d6bcb105c3 on Oct 20, 2022
  30. dhruv referenced this in commit c27eb1e66a on Oct 20, 2022
  31. dhruv referenced this in commit a2e91d2816 on Oct 20, 2022
  32. dhruv referenced this in commit 0b21533c10 on Oct 21, 2022
  33. dhruv referenced this in commit 01dddb4cf6 on Oct 21, 2022
  34. dhruv referenced this in commit a0bb5b6946 on Nov 17, 2022
  35. dhruv referenced this in commit 2e4c03dd67 on Nov 17, 2022
  36. dhruv referenced this in commit 388c9b1b55 on Nov 21, 2022
  37. dhruv referenced this in commit 244eb87643 on Dec 7, 2022
  38. dhruv referenced this in commit 92cddabc43 on Dec 8, 2022
  39. sipa referenced this in commit 9d47e7b71b on Dec 13, 2022
  40. dhruv referenced this in commit 55ffd47cc6 on Dec 14, 2022
  41. dhruv referenced this in commit 967c65b158 on Dec 14, 2022
  42. dhruv referenced this in commit 78b5ddf28b on Jan 11, 2023
  43. dhruv referenced this in commit 215394a1d5 on Jan 11, 2023
  44. div72 referenced this in commit 945b094575 on Mar 14, 2023
  45. str4d referenced this in commit 0df7b459f6 on Apr 21, 2023
  46. vmta referenced this in commit e1120c94a1 on Jun 4, 2023
  47. vmta referenced this in commit 8f03457eed on Jul 1, 2023
  48. jonasnick cross-referenced this on Jul 17, 2023 from issue Upstream PRs 1056, 1104, 1105, 1084, 1114, 1115, 1116, 1120, 1122, 1121, 1128, 1131, 1144, 1150, 1146 by jonasnick

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 20:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me