cmake: Rename project to “libsecp256k1” #1229
pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:230308-cmake changing 3 files +18 −18-
hebasto commented at 9:22 pm on March 8, 2023: memberWas discussed today on IRC.
-
cmake: Rename project to "libsecp256k1" 8be82d4362
-
in examples/CMakeLists.txt:12 in 8be82d4362
8@@ -9,9 +9,9 @@ target_link_libraries(example INTERFACE 9 $<$<PLATFORM_ID:Windows>:bcrypt> 10 ) 11 if(SECP256K1_BUILD_SHARED) 12- target_link_libraries(example INTERFACE ${PROJECT_NAME}) 13+ target_link_libraries(example INTERFACE secp256k1)
sipa commented at 9:31 pm on March 8, 2023:I’d change these too, tolibsecp256k1
andlibsecp256k1_static
.
real-or-random commented at 9:35 pm on March 8, 2023:I’d change these too, to libsecp256k1 and libsecp256k1_static.
Does this actually work?
real-or-random commented at 9:48 pm on March 8, 2023:No, we need to keep it like this. We could improve this after the release by defining a variable by taking a substring of PROJECT_NAME. -
real-or-random approved
-
real-or-random commented at 9:47 pm on March 8, 2023: contributorACK 8be82d43628138553bc126a76d52edf523031792
-
sipa commented at 9:56 pm on March 8, 2023: contributorACK 8be82d43628138553bc126a76d52edf523031792
-
sipa merged this on Mar 8, 2023
-
sipa closed this on Mar 8, 2023
-
hebasto deleted the branch on Mar 8, 2023
-
sipa referenced this in commit 763079a3f1 on Mar 8, 2023
-
real-or-random cross-referenced this on Mar 8, 2023 from issue build: Meta-issue for follow-ups to initial CMake merge (#1113) by real-or-random
-
real-or-random cross-referenced this on Mar 10, 2023 from issue build: Meta-issue for follow-ups to initial CMake merge (#1113) by hebasto
-
div72 referenced this in commit 945b094575 on Mar 14, 2023
-
vmta referenced this in commit e1120c94a1 on Jun 4, 2023
-
vmta referenced this in commit 8f03457eed on Jul 1, 2023
-
jonasnick cross-referenced this on Jul 21, 2023 from issue Upstream PRs 1113, 1225, 1227, 1229, 1223 by jonasnick