build: Fix C4005 "macro redefinition" MSVC warnings in examples #1275

pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:230412-msvc-warn changing 3 files +6 −4

hebasto commented at 11:13 AM on April 12, 2023: member
This PR:
- fixes C4005 "macro redefinition" MSVC warnings in examples
- removes warning suppressions in both build systems, Autotools-based and CMake-based ones
in examples/examples_util.h:27 in 263fc29663 outdated
```
  16 | @@ -17,7 +17,9 @@
  17 |   */
  18 |  
  19 |  #if defined(_WIN32)
  20 | +#define WIN32_NO_STATUS
  21 |  #include <windows.h>
  22 | +#undef WIN32_NO_STATUS
  23 |  #include <ntstatus.h>
```
real-or-random commented at 2:47 PM on April 12, 2023:

This is so obscure. Perhabs add a comment here.

I found https://www.mschaef.com/windows_h_is_wierd

hebasto commented at 2:48 PM on April 12, 2023:

Mind suggesting a good wording for a comment?

hebasto commented at 11:52 AM on April 13, 2023:

This is so obscure. Perhabs add a comment here.

Thanks! Updated.
build: Fix C4005 "macro redefinition" MSVC warnings in examples dc0657c762
hebasto force-pushed on Apr 13, 2023
hebasto commented at 11:52 AM on April 13, 2023: member
Updated 263fc296632060b8d2320f4382f06430fee3421e -> dc0657c7622f5a13afc3876eca7e2fc7cabb9a10 (pr1275.01 -> pr1275.02, diff):
- addressed @real-or-random's comment
real-or-random approved
real-or-random commented at 5:49 PM on April 20, 2023: contributor

utACK dc0657c7622f5a13afc3876eca7e2fc7cabb9a10
real-or-random merged this on Apr 26, 2023
real-or-random closed this on Apr 26, 2023
real-or-random commented at 3:53 PM on April 26, 2023: contributor

ACK dc0657c7622f5a13afc3876eca7e2fc7cabb9a10 I tested that the examples compile without warnings on MSVC 19.34.31942
hebasto deleted the branch on Apr 27, 2023
sipa referenced this in commit b4eb644b6c on May 12, 2023
hebasto referenced this in commit 49c52ea2b1 on May 13, 2023
vmta referenced this in commit e1120c94a1 on Jun 4, 2023
sipa referenced this in commit 901336eee7 on Jun 21, 2023
vmta referenced this in commit 8f03457eed on Jul 1, 2023
hebasto referenced this in commit 92da1e48c3 on Jul 20, 2023
hebasto referenced this in commit 7e4521f4a7 on Jul 21, 2023
hebasto referenced this in commit 1c68202ec6 on Jul 21, 2023
jonasnick cross-referenced this on Jul 24, 2023 from issue Upstream PRs 1268, 1276, 1267, 1265, 1230, 1279, 1273, 1263, 1231, 1285, 1283, 1205, 1286, 1275, 1234, 1239, 1240, 1284, 1277, 1289, 1270, 1296, 1301, 1299, 1066, 1300, 1292, 1305, 1303, 1133, 1306, 1207, 1304, 1307, 1311, 1309, 1312 by jonasnick

Contributors

hebasto

real-or-random