Remove secp256k1_fe_const_b #1282

1. 
   roconnor-blockstream commented at 6:12 pm on April 20, 2023: contributor

   It’s last use was eliminated in #1217.
2. Remove secp256k1_fe_const_b

   It's last use was eliminated in #1217.

   d6be470ee5
3. real-or-random approved
4. 
   real-or-random commented at 6:13 pm on April 20, 2023: contributor

   utACK d6be470ee574b58bbd222a5c14cd867fc0a7a363
5. 
   sipa commented at 6:18 pm on April 20, 2023: contributor

   0src/tests.c: In function 'ecmult_const_mult_xonly':
   1src/tests.c:4501:35: error: 'secp256k1_fe_const_b' undeclared (first use in this function); did you mean 'secp256k1_ge_const_g'?
   2 4501 |             secp256k1_fe_add(&c, &secp256k1_fe_const_b);
   3      |                                   ^~~~~~~~~~~~~~~~~~~~
   4      |                                   secp256k1_ge_const_g
   

   It would appear that #1118 added another use back (which can easily be converted to secp256k1_fe_add_int() instead).

6. 
   real-or-random commented at 6:27 pm on April 20, 2023: contributor

   0src/tests.c: In function 'ecmult_const_mult_xonly':
   1src/tests.c:4501:35: error: 'secp256k1_fe_const_b' undeclared (first use in this function); did you mean 'secp256k1_ge_const_g'?
   2 4501 |             secp256k1_fe_add(&c, &secp256k1_fe_const_b);
   3      |                                   ^~~~~~~~~~~~~~~~~~~~
   4      |                                   secp256k1_ge_const_g
   

   It would appear that #1118 added another use back (which can easily be converted to secp256k1_fe_add_int() instead.)

   By the way, this shows that it’s a good idea to remove secp256k1_fe_const_b to make sure that noone will use it in the future.

7. roconnor-blockstream closed this on Apr 20, 2023

   ---

8. 
   sipa commented at 8:25 pm on April 20, 2023: contributor

   See #1283 for a fix.
9. sipa cross-referenced this on Apr 20, 2023 from issue Get rid of secp256k1_fe_const_b by sipa
10. real-or-random referenced this in commit f6bef03c0a on Apr 21, 2023

Contributors
roconnor-blockstream real-or-random sipa