Closes #1324.
As the __shiftright128
docs state:
The
Shift
value is always modulo 64…
it is not applicable for the n >= 64
branch.
__shiftright128
intrinsic in secp256k1_u128_rshift
on MSVC
#1336
Thanks for working on this.
it is not applicable for the
n >= 64
branch.
Good point, can you add a VERIFY_CHECK(n < 64);
over the intrinsic line to document this?
This #ifdef should be active on CI, right? So this is tested on CI? It may make sense to add a few simple (fixed-input) tests for that function.
it is not applicable for the
n >= 64
branch.Good point, can you add a
VERIFY_CHECK(n < 64);
over the intrinsic line to document this?
Added.
This #ifdef should be active on CI, right?
Yes.
So this is tested on CI?
It is.
It may make sense to add a few simple (fixed-input) tests for that function.
In addition to https://github.com/bitcoin-core/secp256k1/blob/60556c9f49a9384efd7f16b734820ae19108f053/src/tests.c#L1990-L1995 ?
utACK 5b7bf2e9d4ee02cbec1105ad6e890c34a4da1beb
In addition to …
Sorry, I missed the existing test.
Labels
performance