Corrected some typos #1370

1. 
   criadoperez commented at 1:22 pm on July 3, 2023: contributor

   Corrected some typos
2. in src/wycheproof/ecdsa_secp256k1_sha256_bitcoin_test.json:13 in d45a7f8697 outdated

    9@@ -10,7 +10,7 @@
   10   "notes" : {
   11     "ArithmeticError" : {
   12       "bugType" : "EDGE_CASE",
   13-      "description" : "Some implementations of ECDSA have arithmetic errors that occur when intermediate results have extreme values. This test vector has been constructed to test such occurences.",
   14+      "description" : "Some implementations of ECDSA have arithmetic errors that occur when intermediate results have extreme values. This test vector has been constructed to test such occurrences.",
   

   ---

   ---

   

   sipa commented at 1:35 pm on July 3, 2023:

   This file is copied literally from Project Wycheproof (https://github.com/google/wycheproof), specifically https://github.com/google/wycheproof/blob/master/testvectors_v1/ecdsa_secp256k1_sha256_bitcoin_test.json. If there are typos in it, they should be fixed there first.

   ---

   

   criadoperez commented at 1:46 pm on July 3, 2023:

   Thanks @sipa I have just submitted a PR over there for this.
3. in src/wycheproof/ecdsa_secp256k1_sha256_bitcoin_test.json:1 in d45a7f8697

   ---

   ---

   

   real-or-random commented at 1:37 pm on July 3, 2023:

   This file is a copy of https://github.com/google/wycheproof/blob/master/testvectors_v1/ecdsa_secp256k1_sha256_bitcoin_test.json . I don’t think we want to touch it here. Please report upstream instead.
4. 
   real-or-random commented at 1:37 pm on July 3, 2023: contributor

   Thanks!

   ACK mod the wycheproof file

5. real-or-random added the label documentation on Jul 3, 2023
6. 
   criadoperez commented at 1:54 pm on July 3, 2023: contributor

   Removed the changes form the ecdsa_secp256k1_sha256_bitcoin_test.json file
7. 
   hebasto commented at 1:55 pm on July 3, 2023: member

   @criadoperez Mind squashing all your commits into one?
8. 
   criadoperez commented at 1:58 pm on July 3, 2023: contributor

   Sure thing. No need to have multiple.
9. 
   real-or-random commented at 2:13 pm on July 3, 2023: contributor

   Oh, I think @hebasto was asking if you could squash the commits into a single one (and force-push your branch). Our usual workflow is that the PR author squashes, not the person merging.
10. small fixes

    restoring wycheproof files
    
    restoring wycheproof files2

    b6b9834e8d
11. criadoperez force-pushed on Jul 3, 2023
12. 
    criadoperez commented at 3:08 pm on July 3, 2023: contributor

    Done. Squashed into one.
13. real-or-random approved
14. 
    real-or-random commented at 3:27 pm on July 3, 2023: contributor

    ACK b6b9834e8da7f3fd91b95f750a4ee7a10bf67435
15. real-or-random merged this on Jul 3, 2023
16. real-or-random closed this on Jul 3, 2023

    ---

17. criadoperez deleted the branch on Jul 3, 2023
18. fanquake referenced this in commit 56c05c5ec4 on Jul 17, 2023
19. fanquake referenced this in commit ff061fde18 on Jul 18, 2023
20. hebasto referenced this in commit 270d2b37b8 on Jul 21, 2023
21. jonasnick cross-referenced this on Jul 27, 2023 from issue Upstream PRs 1357, 1345, 1358, 1368, 1369, 1323, 1364, 1370, 1367, 1344, 1371, 1363, 1340, 1366, 1313, 1378, 1298, 1382, 1383, 1384, 1386 by jonasnick

Contributors
criadoperez sipa real-or-random hebasto

Labels
documentation