release: Prepare for 0.4.0 #1415

pull real-or-random wants to merge 2 commits into bitcoin-core:master from real-or-random:202309-0.4.0 changing 3 files +20 −12
  1. real-or-random commented at 2:17 pm on September 4, 2023: contributor
  2. real-or-random force-pushed on Sep 4, 2023
  3. in CHANGELOG.md:16 in 3db0b4f052 outdated
    12  - New module `ellswift` implements ElligatorSwift encoding for public keys and x-only Diffie-Hellman key exchange for them.
    13    ElligatorSwift permits representing secp256k1 public keys as 64-byte arrays which cannot be distinguished from uniformly random. See:
    14    - Header file `include/secp256k1_ellswift.h` which defines the new API.
    15    - Document `doc/ellswift.md` which explains the mathematical background of the scheme.
    16    - The [paper](https://eprint.iacr.org/2022/759) on which the scheme is based.
    17+ - We now test the library with unreleased development snapshots of GCC and Clang. This gives us an early chance to catch miscompilations and constant-time issues introduced by the compiler (such as these that led to the previous two releases).
    


    jonasnick commented at 2:21 pm on September 4, 2023:
    these -> those?
  4. real-or-random force-pushed on Sep 4, 2023
  5. real-or-random force-pushed on Sep 4, 2023
  6. real-or-random force-pushed on Sep 4, 2023
  7. in CHANGELOG.md:19 in f44e473b50 outdated
    12@@ -13,6 +13,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
    13    - Header file `include/secp256k1_ellswift.h` which defines the new API.
    14    - Document `doc/ellswift.md` which explains the mathematical background of the scheme.
    15    - The [paper](https://eprint.iacr.org/2022/759) on which the scheme is based.
    16+ - We now test the library with unreleased development snapshots of GCC and Clang. This gives us an early chance to catch miscompilations and constant-time issues introduced by the compiler (such as these that led to the previous two releases).
    17+
    18+#### Fixed
    19+ - Certain internal library symbols are no longer exported on Windows DLL builds.
    


    hebasto commented at 2:42 pm on September 4, 2023:

    Maybe drop the word “Certain”?

    I’m not a native English speaker, but the sentence in its current variant makes me think that there are still internal symbols that are exported.


    real-or-random commented at 2:50 pm on September 4, 2023:
    rephrased
  8. real-or-random force-pushed on Sep 4, 2023
  9. in CHANGELOG.md:16 in aae18e4431 outdated
    13    ElligatorSwift permits representing secp256k1 public keys as 64-byte arrays which cannot be distinguished from uniformly random. See:
    14    - Header file `include/secp256k1_ellswift.h` which defines the new API.
    15    - Document `doc/ellswift.md` which explains the mathematical background of the scheme.
    16    - The [paper](https://eprint.iacr.org/2022/759) on which the scheme is based.
    17- - We now test the library with unreleased development snapshots of GCC and Clang. This gives us an early chance to catch miscompilations and constant-time issues introduced by the compiler (such as these that led to the previous two releases).
    18+ - We now test the library with unreleased development snapshots of GCC and Clang. This gives us an early chance to catch miscompilations and constant-time issues introduced by the compiler (such as those that led to the previous two releases).
    


    hebasto commented at 2:53 pm on September 4, 2023:
    Sorry for nit-picking, but this change belongs to the previous commit, no?

    real-or-random commented at 2:55 pm on September 4, 2023:
    fixed
  10. real-or-random force-pushed on Sep 4, 2023
  11. hebasto approved
  12. hebasto commented at 2:57 pm on September 4, 2023: member
    ACK 50e7da635c0212effa6d20771f6cfc1a7a0b092f
  13. jonasnick cross-referenced this on Sep 4, 2023 from issue release cleanup: bump version after 0.4.0 by jonasnick
  14. jonasnick approved
  15. jonasnick commented at 4:08 pm on September 4, 2023: contributor
    ACK 50e7da635c0212effa6d20771f6cfc1a7a0b092f
  16. in CHANGELOG.md:19 in 50e7da635c outdated
    15@@ -16,11 +16,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
    16  - We now test the library with unreleased development snapshots of GCC and Clang. This gives us an early chance to catch miscompilations and constant-time issues introduced by the compiler (such as those that led to the previous two releases).
    17 
    18 #### Fixed
    19- - Certain internal library symbols are no longer exported on Windows DLL builds.
    20+ - Fixed symbol visibility in Windows DLL builds, where three internal library symbols were wrongly exported.
    


    sipa commented at 4:12 pm on September 4, 2023:
    This is changed in the wrong commit.

    real-or-random commented at 4:20 pm on September 4, 2023:
    Ha, damn. -.- Forced push… git diff 50e7da63..16339804 should be empty.
  17. hebasto commented at 4:18 pm on September 4, 2023: member

    ABI-compatibility tool report:

    image

    image

    image

  18. changelog: Catch up in preparation of release d9a85065a9
  19. release: Prepare for 0.4.0 16339804c9
  20. sipa commented at 4:18 pm on September 4, 2023: contributor
    @hebasto Cool! That looks exactly right.
  21. real-or-random force-pushed on Sep 4, 2023
  22. hebasto commented at 4:21 pm on September 4, 2023: member
    re-ACK 16339804c906a99a0b9bbe192d3de9fde021ff19.
  23. sipa commented at 4:23 pm on September 4, 2023: contributor
    ACK 16339804c906a99a0b9bbe192d3de9fde021ff19
  24. jonasnick approved
  25. jonasnick commented at 4:23 pm on September 4, 2023: contributor
    ACK 16339804c906a99a0b9bbe192d3de9fde021ff19
  26. jonasnick merged this on Sep 4, 2023
  27. jonasnick closed this on Sep 4, 2023

  28. real-or-random referenced this in commit cbf3053ff1 on Sep 4, 2023
  29. sipa referenced this in commit c0da4f60e2 on Sep 4, 2023
  30. real-or-random added the label release on Sep 4, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-30 01:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me