changelog: add entry for "field: Remove x86_64 asm" #1451

pull jonasnick wants to merge 1 commits into bitcoin-core:master from jonasnick:changelog changing 1 files +2 −0
  1. jonasnick commented at 2:23 PM on December 5, 2023: contributor

    No description provided.

  2. real-or-random commented at 3:39 PM on December 5, 2023: contributor
    • I found it a bit confusing to mention that now --with-asm is faster when we say at the same time that we remove asm.
    • Just --with-asm doesn't work because that is equivalent to --with-asm= (empty string), you need --with-asm=x86_64.
    • This should probably also mention the CMake option
    • nit: We use the spelling x86_64 in other places (e.g., user-facing build system stuff)
    • not sure if we need to include the link to the benchmark.

    Suggestion: Optional handwritten x86_64 assembly for field operations was removed because modern C compilers are able to output more efficient assembly. This change results in a significant speedup of some library functions when handwritten x86_64 assembly is enabled (--with-asm=x86_64 in GNU Autotools, -DSECP256K1_ASM=x86_64 in CMake), which is the default on x86_64. Benchmarks with GCC 10.5.0 show a 10% speedup for secp256k1_ecdsa_verify and secp256k1_schnorrsig_verify (see #726 (comment)).

  3. real-or-random added this to the milestone 0.4.1 on Dec 5, 2023
  4. real-or-random added the label user-documentation on Dec 5, 2023
  5. changelog: add entry for "field: Remove x86_64 asm" d2e36a2b81
  6. jonasnick force-pushed on Dec 5, 2023
  7. jonasnick commented at 8:51 PM on December 5, 2023: contributor

    Replaced with your suggestion

  8. real-or-random commented at 9:59 PM on December 5, 2023: contributor

    ACK d2e36a2b81c0ba9d28425ea14c1ff6523156ee52

    (see #726 (comment)).

    Just checking if you omitted this intentionally. If you ask me, it's perfectly fine to omit it, we usually don't link to the related issues/PRs in the Changelog, so it's, in fact, consistent with the current changelog.

  9. jonasnick commented at 5:15 PM on December 6, 2023: contributor

    Yes, omitted intentionally.

  10. real-or-random merged this on Dec 6, 2023
  11. real-or-random closed this on Dec 6, 2023

  12. fanquake referenced this in commit 41e1b677ca on Jan 3, 2024
  13. fanquake referenced this in commit 29fde0223a on Jan 4, 2024
  14. janus referenced this in commit 5fe435c9b2 on Apr 6, 2024
  15. hebasto referenced this in commit b6de625950 on May 11, 2024
  16. delta1 referenced this in commit 6089844b3c on Apr 2, 2025
  17. div72 referenced this in commit af627d47c3 on Apr 12, 2025
  18. str4d referenced this in commit 136aa9fe62 on Jun 4, 2025
  19. oskarszoon referenced this in commit 0d5c9260f4 on Jul 1, 2025

Milestone
0.4.1


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-18 19:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me