tests: Make CHECK enforce 1 instead of just “!= 0” #1481

1. 
   real-or-random commented at 3:24 pm on January 11, 2024: contributor

   This ensures that we don’t omit the “== 1” in tests accidentally, and thus also strengthens existing tests in which it has been omitted.

   We want to check “== 1” in particular for the return values of API functions, but it also makes sense in the case of internal functions.

   If you really want to check “!= 0”, you can still write it explicitly.

   ---

   The second commit drops all the redundant “== 1"s. I tried to be careful to drop it only where it makes sense. Now, git grep "== 1" shows only instances where the 1 is supposed to be an actual integer and not a boolean. Still, this touches many lines, so I can drop this commit if you think it’s too intrusive.

2. tests: Make CHECK enforce 1 instead of just "!= 0"

   This ensures that we don't omit the "== 1" in tests accidentally,
   and thus also strengthens existing tests in which it has been omitted.
   
   We want to check "== 1" in particular for the return values of API
   functions, but it also makes sense in the case of internal functions.
   
   If you really want to check "!= 0", you can still write it explicitly.

   8e5bd3b063
3. tests: Drop redundant "== 1" in CHECKs d9c1688b2d
4. real-or-random added the label assurance on Jan 11, 2024
5. 
   jonasnick commented at 10:41 am on January 15, 2024: contributor

   concept ACK
6. 
   jonasnick commented at 10:42 am on January 15, 2024: contributor

   The second commit drops redundant “-1”.

   You mean “== 1”?

7. 
   theStack commented at 10:08 pm on August 20, 2024: contributor

   Concept ACK

Contributors
real-or-random jonasnick theStack

Labels
assurance