ci: Add native macOS arm64 job #1488

pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:240131-ci-arm changing 1 files +59 −3

hebasto commented at 9:00 PM on January 31, 2024: member

This PR starts using the new M1 macOS runner.

The alternative approach might be using a matrix, but it is not trivial to implement.
ci: Add native macOS arm64 job 218f0cc93b
real-or-random added the label assurance on Feb 1, 2024
real-or-random added the label ci on Feb 1, 2024
in .github/workflows/ci.yml:589 in 218f0cc93b
```
 584 | @@ -585,10 +585,10 @@ jobs:
 585 |          run: env
 586 |          if: ${{ always() }}
 587 |  
 588 | -  macos-native:
 589 | -    name: "x86_64: macOS Monterey"
 590 | +  x86_64-macos-native:
 591 | +    name: "x86_64: macOS Monterey, Valgrind"
```
real-or-random commented at 9:19 AM on February 1, 2024:

Did you remove the "Valgrind" intentionally?

hebasto commented at 9:32 AM on February 1, 2024:

Do you mean in the #1412?

real-or-random commented at 9:35 AM on February 1, 2024:

No, I mean you have removed the substring ", Valgrind" from the job name. :D

hebasto commented at 9:38 AM on February 1, 2024:

Sorry, I don't follow... The diff appends the substring ", Valgrind" to the job name, no?

real-or-random commented at 1:12 PM on February 1, 2024:

Lol sure, sorry, nevermind...
real-or-random commented at 9:21 AM on February 1, 2024: contributor

Concept ACK

It's a bit sad that we can't run Valgrind on the new machines yet.
real-or-random commented at 9:56 AM on May 30, 2024: contributor

I think it will be good to add an MSan job with ctimetests enabled. We have an arm64 job with Valgrind on Linux (Cirrus CI), but I guess having a ctimetest for macOS (Apple clang) can't hurt.
hebasto force-pushed on May 30, 2024
hebasto marked this as a draft on May 30, 2024
hebasto commented at 1:00 PM on May 30, 2024: member
I think it will be good to add an MSan job with ctimetests enabled. We have an arm64 job with Valgrind on Linux (Cirrus CI), but I guess having a ctimetest for macOS (Apple clang) can't hurt.

For both Apple Clang and LLVM Clang, I have:
```
clang: error: unsupported option '-fsanitize=memory' for target 'arm64-apple-darwin23.5.0'
```
hebasto force-pushed on May 30, 2024
hebasto marked this as ready for review on May 30, 2024
real-or-random commented at 1:37 PM on May 30, 2024: contributor

Ok, damn, I didn't know that MSan is not supported on macOS... https://github.com/google/sanitizers/issues/588
real-or-random approved
real-or-random commented at 8:35 AM on May 31, 2024: contributor

ACK 218f0cc93bd77eae926f4c4e259951b92bf00aec
real-or-random merged this on Jun 10, 2024
real-or-random closed this on Jun 10, 2024
hebasto deleted the branch on Jun 10, 2024

Contributors

hebasto

real-or-random

Labels

assurance ci