ci: Add native macOS arm64 job #1488

pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:240131-ci-arm changing 1 files +59 −3
  1. hebasto commented at 9:00 pm on January 31, 2024: member

    This PR starts using the new M1 macOS runner.

    The alternative approach might be using a matrix, but it is not trivial to implement.

  2. ci: Add native macOS arm64 job 218f0cc93b
  3. real-or-random added the label assurance on Feb 1, 2024
  4. real-or-random added the label ci on Feb 1, 2024
  5. in .github/workflows/ci.yml:589 in 218f0cc93b
    584@@ -585,10 +585,10 @@ jobs:
    585         run: env
    586         if: ${{ always() }}
    587 
    588-  macos-native:
    589-    name: "x86_64: macOS Monterey"
    590+  x86_64-macos-native:
    591+    name: "x86_64: macOS Monterey, Valgrind"
    


    real-or-random commented at 9:19 am on February 1, 2024:
    Did you remove the “Valgrind” intentionally?

    hebasto commented at 9:32 am on February 1, 2024:
    Do you mean in the #1412?

    real-or-random commented at 9:35 am on February 1, 2024:
    No, I mean you have removed the substring “, Valgrind” from the job name. :D

    hebasto commented at 9:38 am on February 1, 2024:
    Sorry, I don’t follow… The diff appends the substring “, Valgrind” to the job name, no?

    real-or-random commented at 1:12 pm on February 1, 2024:
    Lol sure, sorry, nevermind…
  6. real-or-random commented at 9:21 am on February 1, 2024: contributor

    Concept ACK

    It’s a bit sad that we can’t run Valgrind on the new machines yet.

  7. real-or-random commented at 9:56 am on May 30, 2024: contributor
    I think it will be good to add an MSan job with ctimetests enabled. We have an arm64 job with Valgrind on Linux (Cirrus CI), but I guess having a ctimetest for macOS (Apple clang) can’t hurt.
  8. hebasto force-pushed on May 30, 2024
  9. hebasto marked this as a draft on May 30, 2024
  10. hebasto commented at 1:00 pm on May 30, 2024: member

    I think it will be good to add an MSan job with ctimetests enabled. We have an arm64 job with Valgrind on Linux (Cirrus CI), but I guess having a ctimetest for macOS (Apple clang) can’t hurt.

    For both Apple Clang and LLVM Clang, I have:

    0clang: error: unsupported option '-fsanitize=memory' for target 'arm64-apple-darwin23.5.0'
    
  11. hebasto force-pushed on May 30, 2024
  12. hebasto marked this as ready for review on May 30, 2024
  13. real-or-random commented at 1:37 pm on May 30, 2024: contributor
    Ok, damn, I didn’t know that MSan is not supported on macOS… https://github.com/google/sanitizers/issues/588
  14. real-or-random approved
  15. real-or-random commented at 8:35 am on May 31, 2024: contributor
    ACK 218f0cc93bd77eae926f4c4e259951b92bf00aec
  16. real-or-random merged this on Jun 10, 2024
  17. real-or-random closed this on Jun 10, 2024

  18. hebasto deleted the branch on Jun 10, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-01 00:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me