- secp256k1_fe_sqrt now checks that the value it calculated is actually a square root.
- Add return values to secp256k1_fe_sqrt and secp256k1_ge_set_xo.
- Callers of secp256k1_ge_set_xo can use return value instead of explicit validity checks
- Add random value tests for secp256k1_fe_sqrt
secp256k1_fe_sqrt checks for success #15
pull peterdettman wants to merge 3 commits into bitcoin-core:master from peterdettman:peterdettman-checked-sqrt changing 6 files +78 −21-
peterdettman commented at 5:44 AM on May 19, 2014: contributor
-
d397954723
secp256k1_fe_sqrt checks for success
- secp256k1_fe_sqrt now checks that the value it calculated is actually a square root. - Add return values to secp256k1_fe_sqrt and secp256k1_ge_set_xo. - Callers of secp256k1_ge_set_xo can use return value instead of explicit validity checks - Add random value tests for secp256k1_fe_sqrt
-
Merge branch 'master' of https://github.com/bitcoin/secp256k1 into peterdettman-checked-sqrt 535271b1fb
-
Check against known-answer in test-sqrt db8a9c5589
-
sipa commented at 6:07 PM on May 19, 2014: contributor
Very nice - thanks especially for increasing the test coverage!
One nit: can you squash the commits?
-
peterdettman commented at 1:00 PM on May 20, 2014: contributor
@sipa Can do; I'll try to get to it tomorrow.
-
peterdettman commented at 3:53 AM on May 21, 2014: contributor
Closed in favour of a new pull request with the commits squashed.
- peterdettman closed this on May 21, 2014
-
laanwj commented at 9:08 AM on May 21, 2014: member
@peterdettman you don't need to open a new pull when you squash the commits, you can just squash then force-push to the same branch and it will appear in the current one.
-
peterdettman commented at 10:01 AM on May 21, 2014: contributor
@laanwj ok, I'll remember for next time.
- peterdettman deleted the branch on May 22, 2014
Contributors