tests: call secp256k1_ecmult_multi_var with a non-NULL error callback #1528

1. 
   niooss-ledger commented at 5:17 pm on May 8, 2024: contributor

   Hello, This Pull Request fixes the issue reported in #1527. Function secp256k1_ecmult_multi_var expects to be called with a non-NULL error_callback parameter. Fix the invocation in test_ecmult_accumulate to do this. While at it, wrap the call in a CHECK macro to ensure it succeeds.
2. tests: call secp256k1_ecmult_multi_var with a non-NULL error callback

   Function secp256k1_ecmult_multi_var expects to be called with a non-NULL
   error_callback parameter. Fix the invocation in test_ecmult_accumulate
   to do this.
   
   While at it, wrap the call in a CHECK macro to ensure it succeeds.
   
   Fixes: https://github.com/bitcoin-core/secp256k1/issues/1527

   9554362b15
3. real-or-random approved
4. 
   real-or-random commented at 7:49 am on May 9, 2024: contributor

   utACK 9554362b1532d8292ab805cefb9c886cd55ac205
5. real-or-random added the label bug on May 9, 2024
6. real-or-random added the label assurance on May 9, 2024
7. 
   siv2r commented at 8:43 am on May 13, 2024: contributor

   ACK 9554362, I have also verified that other invocations of ecmult_multi_var (in tests) don’t use NULL for the error callback function argument.
8. real-or-random merged this on May 13, 2024
9. real-or-random closed this on May 13, 2024

   ---

10. niooss-ledger deleted the branch on May 13, 2024

Contributors
niooss-ledger real-or-random siv2r

Labels
bug assurance