hebasto
commented at 9:52 am on May 27, 2024:
member
“auto” implies that a value is being chosen based on build system introspection or host system capabilities. However, for the --with-ecmult-window and --with-ecmult-gen-kb options, the values “auto” are hardcoded, which might lead to confusion.
This PR replaces “auto” with more appropriate default values.
If Concept ACKed, I’ll add equivalent commits for CMake.
autotools: Remove "auto" value of `--with-ecmult-window` option
"auto" implies that a value is being chosen based on build system
introspection or host system capabilities. However, for the
`--with-ecmult-window` option, the value "auto" is hardcoded, which
might lead to confusion.
This change replaces "auto" with a more appropriate default value.
122dbaeb37
autotools: Remove "auto" value of `--with-ecmult-gen-kb` option
"auto" implies that a value is being chosen based on build system
introspection or host system capabilities. However, for the
`--with-ecmult-gen-kb` option, the value "auto" is hardcoded, which
might lead to confusion.
This change replaces "auto" with a more appropriate default value.
26b94ee92a
hebasto force-pushed
on May 27, 2024
real-or-random
commented at 12:17 pm on May 27, 2024:
contributor
Concept ACK from my side
I think having a default is good enough, we don’t need two layers of indirection (default -> auto -> some number).
cmake: Remove "AUTO" value of `SECP256K1_ECMULT_WINDOW_SIZE` option
"AUTO" implies that a value is being chosen based on build system
introspection or host system capabilities. However, for the
`SECP256K1_ECMULT_WINDOW_SIZE` option, the value "AUTO" is hardcoded,
which might lead to confusion.
This change replaces "AUTO" with a more appropriate default value.
a06805ee74
cmake: Remove "AUTO" value of `SECP256K1_ECMULT_GEN_KB` option
"AUTO" implies that a value is being chosen based on build system
introspection or host system capabilities. However, for the
`SECP256K1_ECMULT_GEN_KB` option, the value "AUTO" is hardcoded, which
might lead to confusion.
This change replaces "AUTO" with a more appropriate default value.
4d9645bee0
hebasto
commented at 12:35 pm on May 27, 2024:
member
If Concept ACKed, I’ll add equivalent commits for CMake.
The equivalent commits for CMake have been added.
real-or-random added the label
build
on May 27, 2024
real-or-random renamed this:
autotools: Replace hardcoded "auto" value with default one
build: Replace hardcoded "auto" value with default one
on May 27, 2024
real-or-random approved
real-or-random
commented at 8:52 pm on May 27, 2024:
contributor
utACK4d9645bee06e732f5d7d9e72b0c26c22c5006eb8 good from my side, but let’s see if we can get more (Concept) ACKs
I think we’d still want to have something like profiles (e.g., “desktop”, “embedded”, “minimal”) eventually, but this change makes sense independently of this.
bitcoin-core deleted a comment
on Jun 13, 2024
fanquake
commented at 8:37 am on June 25, 2024:
member
Concept ACK
sipa
commented at 1:02 pm on June 25, 2024:
contributor
utACK4d9645bee06e732f5d7d9e72b0c26c22c5006eb8
real-or-random merged this
on Jun 25, 2024
real-or-random closed this
on Jun 25, 2024
hebasto deleted the branch
on Jun 25, 2024
real-or-random
commented at 2:03 pm on June 25, 2024:
contributor
Does this need a changelog entry? Strictly speaking yes because this removes a valid config option. But pragmatically, I tend to say no: the breakage occurs only for people who passed =auto (the default) explicitly, so this should hardly affect anyone.
edit: Let me just add the label, we can revisit this when we do the release.
real-or-random added the label
needs-changelog
on Jun 25, 2024
fanquake referenced this in commit
1408944d2e
on Jun 25, 2024
This is a metadata mirror of the GitHub repository
bitcoin-core/secp256k1.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2024-10-29 21:15 UTC
This site is hosted by @0xB10C More mirrored repositories can be found on mirror.b10c.me