cmake: Clean up coverage flags #1557

pull hebasto wants to merge 2 commits into bitcoin-core:master from hebasto:240628-cmake-coverage changing 1 files +1 −12

hebasto commented at 8:35 am on June 28, 2024: member

The CMAKE_C_FLAGS_COVERAGE is a language-wide variable. These flags will be passed to all invocations of the compiler, including invocations that drive compiling and those that drive linking.

Therefore, --coverage in the CMAKE_*_LINKER_FLAGS_COVERAGE variables is redundant.

Also this PR allows the user to override CMAKE_C_FLAGS_COVERAGE by setting a cache variable in the command line.

cmake: Clean up coverage flags

The `CMAKE_C_FLAGS_COVERAGE` is language-wide variable. These flags will
be passed to all invocations of the compiler, including invocations that
drive compiling and those that drive linking.
Therefore, `--coverage` in the `CMAKE_*_LINKER_FLAGS_COVERAGE` variables
is redundant.

ae7bd9e528

cmake: Allow user to override `CMAKE_C_FLAGS_COVERAGE` 83924af566
hebasto marked this as a draft on Jun 28, 2024
hebasto closed this on Jun 28, 2024

Contributors
hebasto