build, ci: Adjust the default size of the precomputed table for signing #1564

1. 
   hebasto commented at 7:52 pm on July 1, 2024: member

   This PR implements the outcomes from today’s IRC meeting:

   1. The default size of the precomputed table for signing is now aligned with Bitcoin Core’s default.

   2. The default value in CI has been updated to reflect the new default.

2. real-or-random added the label ci on Jul 1, 2024
3. real-or-random added the label build on Jul 1, 2024
4. real-or-random added the label performance on Jul 1, 2024
5. build: Adjust the default size of the precomputed table for signing

   The new default value of the precomputed table for signing is aligned
   with Bitcoin Core's default.
   See: https://github.com/bitcoin/bitcoin/commit/a057869aa3c42457570765966cb66accb2375b13

   d94a9273f8
6. ci: Switch to the new default value of the precomputed table for signing e2af491263
7. hebasto force-pushed on Jul 3, 2024
8. real-or-random added the label needs-changelog on Jul 3, 2024
9. 
   real-or-random commented at 1:49 pm on July 3, 2024: contributor

   @sipa @jonasnick

   I wonder how much this is a breaking change. 86 KB is larger than the old default (64KB), so this could be a problem for some users. But since we use static precomputation, this will be at most a build-time issue, so I don’t think it deserves a 0.6.0 instead of 0.5.1 (assuming it makes it to the next release).

10. 
    hebasto commented at 1:51 pm on July 3, 2024: member

    … I don’t think it deserves a 0.6.0 instead of 0.5.1 (assuming it makes it to the next release).

    I agree because there are no API changes.

11. real-or-random approved
12. 
    real-or-random commented at 1:53 pm on July 3, 2024: contributor

    utACK e2af491263e2f7e086dc7f1925d86660ff265dc6
13. 
    sipa commented at 3:00 pm on July 3, 2024: contributor

    utACK e2af491263e2f7e086dc7f1925d86660ff265dc6

    I agree this is not a breaking change, though it does deserve a release note.

14. real-or-random merged this on Jul 3, 2024
15. real-or-random closed this on Jul 3, 2024

    ---

16. hebasto deleted the branch on Jul 3, 2024
17. josibake referenced this in commit d331f4d7b4 on Jul 15, 2024
18. josibake referenced this in commit 5a0b27cf3c on Jul 15, 2024
19. fanquake referenced this in commit 41797f8ab9 on Aug 2, 2024
20. fanquake referenced this in commit d928f4c47f on Aug 6, 2024
21. vmta referenced this in commit f2a8540eae on Sep 3, 2024
22. vmta referenced this in commit 8c2166b973 on Sep 6, 2024
23. vmta referenced this in commit 4d1f6d5635 on Oct 29, 2024
24. real-or-random removed the label needs-changelog on Nov 4, 2024

Contributors
hebasto real-or-random sipa

Labels
ci build performance