Schnorr (Incremental) Half Aggregation #1566

1. 
   fjahr commented at 3:24 pm on July 2, 2024: contributor

   This ports over the work from b-wagn in https://github.com/BlockstreamResearch/secp256k1-zkp/pull/261

   In the second commit I have addressed the follow-ups though I was not always sure if I understood them correctly since they weren’t inline. Please let me know if they are correct then I can squash the commit here and open it as a PR on zkp.

2. fjahr force-pushed on Jul 2, 2024
3. real-or-random added the label feature on Jul 2, 2024
4. fjahr force-pushed on Jul 2, 2024
5. jjones3695 approved
6. bitcoin-core deleted a comment on Jul 16, 2024
7. bitcoin-core deleted a comment on Jul 16, 2024
8. bitcoin-core deleted a comment on Jul 16, 2024
9. fjahr force-pushed on Nov 18, 2024
10. fjahr force-pushed on Nov 18, 2024
11. 
    fjahr commented at 4:17 pm on November 18, 2024: contributor

    Rebased on the musig changes and added the compile options for cmake
12. fjahr force-pushed on Nov 18, 2024
13. fjahr force-pushed on Nov 18, 2024
14. fjahr force-pushed on Nov 18, 2024
15. fjahr force-pushed on Nov 18, 2024
16. fjahr force-pushed on Nov 26, 2024
17. fjahr force-pushed on Dec 16, 2025
18. 
    fjahr commented at 10:53 pm on December 16, 2025: contributor

    Rebased to take into account the latest changes to cmake, CI and test framework. Also squashed the commit since maintaining them was annoying and there wasn’t really a good reason for them. It was more of a crutch for me while I was taking my first steps here.
19. Experimental: Add incremental half-aggregation for Schnorr signatures

    This includes addressing nits from the halfagg PR in secp-zkp:
    - we may want to add a header to the include file that links to the BIP
    - there's still a mention of aggsig_size
    - we may want to move aggregate before inc_aggregate
    - we should mention expected size of input aggsig array in_aggregate
    - 'Should be aggsig_len = 32*(n+1)' -> 'Must be'
    
    Co-authored-by: Benedikt <crypto@benedikt-wagner.dev>

    ccc826d1ff
20. fjahr force-pushed on Dec 16, 2025

Contributors
fjahr jjones3695

Labels
feature