Remove deprecated _ec_privkey_{negate,tweak_add,tweak_mul} aliases from API #1593

1. 
   theStack commented at 11:46 pm on August 20, 2024: contributor

   These function aliases have been described as DEPRECATED in the public API docs already many years ago (see #701, commit 41fc7856), and in addition explicit deprecation warnings are shown by the compiler at least since the first official release 0.2.0 (see PR #1089, commit fc94a2da), so it should be fine to just remove them by now without causing bad surprises to any users.

   Note that this PR intentionally doesn’t include other deprecated flags/types/aliases by now, as they all have been introduced or marked as deprecated later (though the compiler deprecation warnings have been introduced at the same time). There are no deprecation rules yet and seemingly no removal of deprecated types/functions has ever happened so far, so it might make sense to discuss how to handle deprecation in general and introduce guidelines in the future.

2. 
   stratospher commented at 8:40 am on February 24, 2025: contributor

   ACK 5ce9b57.
3. in CHANGELOG.md:13 in 5ce9b577f9 outdated

    6@@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
    7 
    8 ## [Unreleased]
    9 
   10+#### Removed
   11+- The previously deprecated function aliases `secp256k1_ec_privkey_negate`, `secp256k1_ec_privkey_tweak_add` and
   12+  `secp256k1_ec_privkey_tweak_mul` were removed. The corresponding replacements `secp256k1_ec_seckey_negate`,
   13+  `secp256k1_ec_seckey_tweak_add` and `secp256k1_ec_seckey_tweak_mul` have to be used instead.
   

   ---

   ---

   

   real-or-random commented at 2:28 pm on February 24, 2025:

   nit, slightly shorter without loss of information:

   0- Removed previously deprecated function aliases `secp256k1_ec_privkey_negate`, `secp256k1_ec_privkey_tweak_add`, and
   1  `secp256k1_ec_privkey_tweak_mul`. Use `secp256k1_ec_seckey_negate`,
   2  `secp256k1_ec_seckey_tweak_add`, and `secp256k1_ec_seckey_tweak_mul` instead.
   

4. real-or-random approved
5. 
   real-or-random commented at 2:29 pm on February 24, 2025: contributor

   utACK

   But needs rebase.

   I think it’s totally fine to remove these now. Would be nice to merge this for the same release as #1639 which is also breaking.

6. Remove deprecated _ec_privkey_{negate,tweak_add,tweak_mul} aliases

   These function aliases have been described as DEPRECATED in the public
   API docs already many years ago (see #701, commit 41fc7856), and in
   addition explicit deprecation warnings are shown by the compiler at
   least since the first official release 0.2.0 (see PR #1089, commit
   fc94a2da), so it should be fine to just remove them by now.
   
   Co-authored-by: Tim Ruffing <crypto@timruffing.de>

   37d2c60bec
7. theStack force-pushed on Feb 25, 2025
8. 
   theStack commented at 2:45 pm on February 25, 2025: contributor

   Rebased on master and simplified the changelog as suggested in #1593 (review).
9. real-or-random approved
10. 
    real-or-random commented at 12:11 pm on February 27, 2025: contributor

    utACK 37d2c60beca394e8f4733c65f5d558eb302cac06
11. real-or-random added the label feature on Feb 27, 2025

Contributors
theStack stratospher real-or-random

Labels
feature