cmake: Introduce SECP256K1_APPEND_LDFLAGS variable #1600

pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:240902-append-ldflags changing 1 files +11 −0
  1. hebasto commented at 8:42 pm on September 2, 2024: member

    Downstream projects may include libsecp256k1 test executables in their test suites. In such cases, if a -fsanitize=... flag is passed via the SECP256K1_APPEND_CFLAGS variable, the same flag must also be passed to the linker.

    Required for https://github.com/bitcoin/bitcoin/pull/30791.

  2. cmake: Introduce `SECP256K1_APPEND_LDFLAGS` variable
    Downstream projects may include libsecp test executables in their test
    suites. In such cases, if a `-fsanitize=...` flag is passed via the
    `SECP256K1_APPEND_CFLAGS` variable, the same flag must also be passed to
    the linker.
    421ed1b46f
  3. fanquake commented at 9:54 am on September 6, 2024: member
    Concept ACK - It’d be great if a maintainer could take a look, as we have some changes downstream that are blocked on this.
  4. jonasnick approved
  5. jonasnick commented at 5:02 pm on September 7, 2024: contributor

    @real-or-random sent me a message that he utACKs this and I tested that it works.

    ACK 421ed1b46ff018f33a497df913a11d20f8dd1acc

  6. jonasnick merged this on Sep 7, 2024
  7. jonasnick closed this on Sep 7, 2024

  8. hebasto deleted the branch on Sep 7, 2024
  9. hebasto referenced this in commit 611562806c on Sep 7, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-22 02:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me