Name public API structs #1628

1. 
   achow101 commented at 5:57 pm on October 31, 2024: member

   Closes #1627
2. Name public API structs 694342fdb7
3. real-or-random added the label feature on Nov 1, 2024
4. real-or-random added the label refactor/smell on Nov 1, 2024
5. real-or-random approved
6. 
   real-or-random commented at 4:07 pm on November 1, 2024: contributor

   utACK 694342fdb71722b31dd4b6bc7241b992fdf6f492

   Fwiw, I had discussed this with @jonasnick because we were not sure if reusing the struct tag as the type name is okay also in C++. But while C++ has slightly different rules here, they’re made so that compatibility to C is ensured, see https://stackoverflow.com/questions/1675351/typedef-struct-vs-struct-definitions

7. jonasnick approved
8. 
   jonasnick commented at 4:08 pm on November 1, 2024: contributor

   ACK 694342fdb71722b31dd4b6bc7241b992fdf6f492
9. real-or-random merged this on Nov 1, 2024
10. real-or-random closed this on Nov 1, 2024

    ---

11. real-or-random added the label needs-changelog on Nov 1, 2024
12. 
    real-or-random commented at 4:13 pm on November 1, 2024: contributor

    We may want to add a changelog entry for this PR. The change doesn’t break anything, but it makes using the API more convenient, so users could be interested.
13. achow101 referenced this in commit 378ca17fd1 on Nov 1, 2024
14. 
    gatleas17 commented at 8:24 pm on November 2, 2024: none

    ll

Contributors
achow101 real-or-random jonasnick gatleas17

Labels
feature needs-changelog refactor/smell