use `EXIT_` constants over magic numbers for indicating program execution status #1654

pull theStack wants to merge 3 commits into bitcoin-core:master from theStack:use-exit_-constants changing 15 files +62 −50

theStack commented at 12:56 PM on February 14, 2025: contributor

This simple PR addresses #1609 for all example and internal binaries. Alternative to #1618, which is stale (the author confirmed to me that they are not working on that PR anymore). The last commits adds a suggestion to CONTRIBUTING.md, not sure though if we want to go that far.
examples: use `EXIT_...` constants for `main` return values
Fixes issue #1609.
965393fcea

in src/bench_ecmult.c:303 in 6820e54062 outdated

 299 | @@ -299,7 +300,7 @@ int main(int argc, char **argv) {
 300 |          } else {
 301 |              fprintf(stderr, "%s: unrecognized argument '%s'.\n\n", argv[0], argv[1]);
 302 |              help(argv);
 303 | -            return 1;
 304 | +            return EXIT_FAILURE;

stratospher commented at 4:40 PM on February 14, 2025:

6820e54: there's also an EXIT_SUCCESS few lines above for --help.

theStack commented at 5:05 PM on February 14, 2025:

Good catch, missed that one! Done.

stratospher commented at 4:58 PM on February 14, 2025: contributor

ACK 6724f99.
test, bench, precompute_ecmult: use `EXIT_...` constants for `main` return values c855581728
CONTRIBUTING: mention that `EXIT_` codes should be used 13d389629a
theStack force-pushed on Feb 14, 2025
jonasnick approved
jonasnick commented at 9:26 AM on February 18, 2025: contributor

ACK 13d389629aba2c686798a856332c00c6934cacd5
real-or-random approved
real-or-random commented at 8:55 AM on February 24, 2025: contributor

utACK 13d389629aba2c686798a856332c00c6934cacd5
real-or-random merged this on Feb 24, 2025
real-or-random closed this on Feb 24, 2025
theStack deleted the branch on Feb 24, 2025

Contributors

Linked (view graph)

#1609 use EXIT_ codes instead of magic numbers for exit(...) and main return values #1618 Examples: swap magic numbers for EXIT_ codes