Assert field magnitude at control-flow join #1673

pull peterdettman wants to merge 1 commits into bitcoin-core:master from peterdettman:join changing 1 files +2 −0
  1. peterdettman commented at 10:56 am on May 20, 2025: contributor

    As I was re-reading the xonly method I noticed that the author had taken some care about the magnitude of g in each branch. It’s probably worth documenting magnitude assumptions when control flows join like this.

    Actually I would even prefer a new field method (perhaps _fe_join) that calls SECP256K1_FE_VERIFY_MAGNITUDE, and then sets the magnitude to that value. That would be more in line with the static analysis view of magnitudes that I recall being discussed, though I have not been following closely lately.

  2. Assert field magnitude at control-flow join 3a4f448cb4
  3. sipa commented at 11:56 pm on May 20, 2025: contributor
    ACK 3a4f448cb46eae2aec991b95e4c686de2a4ba906
  4. jonasnick approved
  5. jonasnick commented at 5:48 am on May 24, 2025: contributor
    ACK 3a4f448cb46eae2aec991b95e4c686de2a4ba906
  6. jonasnick merged this on May 24, 2025
  7. jonasnick closed this on May 24, 2025

  8. peterdettman deleted the branch on May 24, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-06-08 17:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me