build: detect arm32 assembly by default #1752

pull Raimo33 wants to merge 2 commits into bitcoin-core:master from Raimo33:detect-arm32-asm changing 1 files +8 −12
  1. Raimo33 commented at 5:29 pm on September 19, 2025: none

    This PR addresses issue #1751 by adding a call to check_arm32_assembly() by default, matching the current behavior with check_x86_64_assembly().

    This would result in speedup on field_10x26_impl.h on default builds. For example, currently, the Bitcoin Core reference implementation compiles libsecp256k1 with default options, leading to unoptimal builds.

  2. Raimo33 force-pushed on Sep 19, 2025
  3. Raimo33 force-pushed on Sep 19, 2025
  4. hebasto commented at 8:28 pm on September 19, 2025: member

    This would result in speedup on field_10x26_impl.h on default builds.

    Please provide benchmarks to support this statement.

  5. Raimo33 force-pushed on Sep 20, 2025
  6. build: remove assembly detection when explicitly disabled 7a613ceac6
  7. Raimo33 force-pushed on Sep 20, 2025
  8. build: detect arm32 assembly by default d767826c54
  9. Raimo33 commented at 2:01 pm on September 22, 2025: none

    Please provide benchmarks to support this statement.

    will do. I’m buying a raspberry PI right now. I reckon if the benchmarks don’t show improvements we should delete field_10x26_arm.s entirely

  10. hebasto commented at 1:15 pm on September 25, 2025: member
    Perhaps convert this to a draft while the CI is red?
  11. Raimo33 marked this as a draft on Sep 25, 2025


Raimo33 hebasto


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-10-13 19:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me