Lingering comment documenting ECMULT_WINDOW_SIZE large values’ costs #1766

issue hebasto openend this issue on November 2, 2025
  1. hebasto commented at 9:49 pm on November 2, 2025: member

    The following comment:https://github.com/bitcoin-core/secp256k1/blob/7a2fff85e8729719f384a094123b965f45ae94db/src/ecmult_impl.h#L33-L41 appears quite confusing to me, as it refers to WINDOW_G, while residing in the code that sets WINDOW_A.

    This comment became lingering and out of context since commit 6815761cf5500f1a619965c5b4bbc8918b334a35.

    Removing it seems reasonable, as its content is already covered by the --with-ecmult-window configuration option help string. However, this would overlook its original purpose to document the ECMULT_WINDOW_SIZE definition when our build system is not used.


hebasto


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-11-05 16:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me