doc/bench: Added cmake build options to bench error messages #1778

1. 
   kevkevinpal commented at 10:10 pm on December 4, 2025: contributor

   Motivation

   I wanted to try and run the benchmarking scripts and I noticed the recovery benchmark in bench.c. I wanted to run but I was using cmake and the error message telling me to use ./configure -enable-module-recovery wasn’t sufficient.

   I figure rather than forcing users to look into the CMakeLists.txt file or anywhere else we should add this to the output

   Solution

   I appended to the message to include the -DSECP256K1_ENABLE_MODULE_...=ON in the message.

2. real-or-random added the label meta/development on Dec 5, 2025
3. 
   real-or-random commented at 8:27 am on December 5, 2025: contributor

   Thanks for spotting this. Maybe a simpler fix (which will be easier to maintain in the future) is to remove this line (or simply refer to the README).
4. kevkevinpal force-pushed on Dec 5, 2025
5. doc/bench: Added cmake build options to bench error messages 3b5b03f301
6. kevkevinpal force-pushed on Dec 5, 2025
7. 
   kevkevinpal commented at 2:26 pm on December 5, 2025: contributor

   Thanks for spotting this. Maybe a simpler fix (which will be easier to maintain in the future) is to remove this line (or simply refer to the README).

   Sounds good I pushed 3b5b03f to replace the message with this instead:

   “See README.md for configuration instructions.\n\n”

   let me know if this looks good, I can reword or simply delete the print if that is wanted

8. real-or-random approved
9. 
   real-or-random commented at 8:54 pm on December 5, 2025: contributor

   utACK 3b5b03f30169903baae7f365cff3137a371a9a8d
10. hebasto approved
11. 
    hebasto commented at 3:04 pm on December 15, 2025: member

    ACK 3b5b03f30169903baae7f365cff3137a371a9a8d, I have reviewed the code and it looks OK.

    Another PR might also improve this comment:https://github.com/bitcoin-core/secp256k1/blob/5c75183344585baee5de74c771099d13613bf7dc/include/secp256k1.h#L352

12. real-or-random merged this on Dec 15, 2025
13. real-or-random closed this on Dec 15, 2025

    ---

Contributors
kevkevinpal real-or-random hebasto

Labels
meta/development