refactor: remove ret from secp256k1_ec_pubkey_serialize #1784

pull kevkevinpal wants to merge 1 commits into bitcoin-core:master from kevkevinpal:refactorRemoveRetECPubkeySerialize changing 1 files +2 −3
  1. kevkevinpal commented at 9:12 pm on December 9, 2025: contributor

    This is a follow-up to #1774 (review)

    It is pretty straightforward to remove ret and to just return either 0 or 1

  2. refactor: remove ret from secp256k1_ec_pubkey_serialize 3daab83a60
  3. real-or-random added the label tweak/refactor on Dec 10, 2025
  4. real-or-random approved
  5. real-or-random commented at 7:38 am on December 10, 2025: contributor
    utACK 3daab83a6050805763da5ac9ebe8217d1965eb0c
  6. theStack approved
  7. theStack commented at 1:34 pm on December 10, 2025: contributor

    ACK 3daab83a6050805763da5ac9ebe8217d1965eb0c

    (fwiw #1774 (review) suggested to return early if _pubkey_load fails, reducing the levels of indentations, but either way seems to be fine, and I haven’t seen a strong preference for one approach over another in our codebase)

  8. real-or-random merged this on Dec 10, 2025
  9. real-or-random closed this on Dec 10, 2025


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-12-17 18:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me