[API BREAK] Make flags more explicit, add runtime checks. #324

pull rustyrussell wants to merge 1 commits into bitcoin-core:master from rustyrussell:flag-safety changing 4 files +39 −21

rustyrussell commented at 4:43 AM on September 29, 2015: contributor

Fewer zeroes, plus check bit to make sure it value is valid.

Signed-off-by: Rusty Russell rusty@rustcorp.com.au
Make flags more explicit, add runtime checks.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
742046526a
jgarzik commented at 12:30 PM on September 29, 2015: none

ut ACK
sipa cross-referenced this on Sep 29, 2015 from issue Extensive interface and operations tests for secp256k1_ec_pubkey_parse. (and some API paranoia improvements) by gmaxwell
in include/secp256k1.h:None in 742046526a
```
 155 | +# define SECP256K1_CONTEXT_SIGN   (SECP256K1_CONTEXT_SIGN_BIT|SECP256K1_CONTEXT_CHECK_BIT)
 156 | +# define SECP256K1_CONTEXT_NONE   (SECP256K1_CONTEXT_CHECK_BIT)
 157 | +
 158 | +#  define SECP256K1_CONTEXT_VERIFY_BIT     (1 << 2)    
 159 | +#  define SECP256K1_CONTEXT_SIGN_BIT       (2 << 2)    
 160 | +#  define SECP256K1_CONTEXT_CHECK_BIT      (1)
```
apoelstra commented at 11:29 AM on October 1, 2015:

I'd prefer VERIFY and SIGN to be (1 << 0) and (1 << 1); COMPRESSED should also be (1 << 0), and in general the actual flags should be written as (1 << n) for increasing n.

The CHECK_BITs would then need to be something high, maybe (1 << 10), (1 << 11), etc, which would give us room for ten flags in each of five different flag categories, while still fitting into a 16-bit int.
apoelstra commented at 11:30 AM on October 1, 2015: contributor

Can you add [API BREAK] to the title of this PR?

Also concept ACK.
rustyrussell renamed this:
~~Make flags more explicit, add runtime checks.~~
[API BREAK] Make flags more explicit, add runtime checks.
on Oct 2, 2015
sipa cross-referenced this on Oct 21, 2015 from issue [API BREAK] Explicit flag handling (rebase + modification of #324) by sipa
sipa commented at 7:11 PM on October 25, 2015: contributor

Superseded by #339.
sipa closed this on Oct 25, 2015

Contributors

Linked (view graph)

#319 Extensive interface and operations tests for secp256k1_ec_pubkey_parse. (and some API paranoia improvements)#339 [API BREAK] Explicit flag handling (rebase + modification of #324)