No description provided.
[API BREAK] Explicit flag handling (rebase + modification of #324) #339
pull sipa wants to merge 2 commits into bitcoin-core:master from sipa:flag-safety changing 6 files +44 −28-
sipa commented at 3:44 PM on October 21, 2015: contributor
- sipa force-pushed on Oct 21, 2015
-
sipa commented at 3:48 PM on October 21, 2015: contributor
This is an update of #324 with the following changes:
- Keep the lower 8 bits of flags to indicate their type
- Revert the change to pass-through the compression flag to the eckey module (which was a layer violation, the flag was defined at a higher level but used on a lower one).
-
sipa commented at 3:49 PM on October 21, 2015: contributor
Comments, @rustyrussell @luke-jr ?
- sipa force-pushed on Oct 21, 2015
- sipa renamed this:
Explicit flag handling (rebase + modification of #324)
[API BREAK] Explicit flag handling (rebase + modification of #324)
on Oct 21, 2015 -
luke-jr commented at 5:24 AM on October 22, 2015: member
I do not understand the reason for pulling flags out of src/eckey_impl.h.
Besides that, fully-reviewed-and-seems-good ACK.
-
sipa commented at 11:24 AM on October 22, 2015: contributor
Luke: the lower-level eckey code should not depend on the top-level wrapper whose interface is exposed.
- sipa force-pushed on Oct 22, 2015
-
sipa commented at 10:37 PM on October 22, 2015: contributor
Rebased, and renamed unsigned int to int for bool flag.
-
1a368980c8
Make flags more explicit, add runtime checks.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
-
Overhaul flags handling 9234391ed4
- sipa force-pushed on Oct 24, 2015
-
- sipa merged this on Oct 25, 2015
- sipa closed this on Oct 25, 2015
- sipa referenced this in commit 73f64ff8f3 on Oct 25, 2015
- sipa cross-referenced this on Oct 25, 2015 from issue [API BREAK] Make flags more explicit, add runtime checks. by rustyrussell
