Update Makefile.am - use gcc for compiling #372

pull doged wants to merge 1 commits into bitcoin-core:master from doged:master changing 1 files +1 −1

doged commented at 11:43 PM on December 30, 2015: none

fixes https://github.com/bitcoin/bitcoin/issues/7261 fresh ubuntu install couldnt find gcc.

Update Makefile.am

fixes https://github.com/bitcoin/bitcoin/issues/7261
fresh ubuntu install couldnt find gcc.

77d8ff2bd8

doged renamed this:
~~Update Makefile.am~~
Update Makefile.am - use gcc for compiling
on Dec 31, 2015
theuni commented at 5:13 PM on January 4, 2016: contributor

NACK. That defeats the purpose of CC_FOR_BUILD. Rather, we should verify that CC_FOR_BUILD can produce a valid binary during configure and exit with a proper error if not.
sipa commented at 7:45 PM on February 16, 2016: contributor

@theuni Can you suggest a solution then?
theuni commented at 8:50 PM on February 16, 2016: contributor

@sipa how about https://github.com/theuni/secp256k1/commit/1fecd7251ea16f41bd5a9324fa184fbca1befc17 ?
laanwj commented at 8:57 AM on February 17, 2016: member

This would hardcode using gcc for build? Definite NACK (think of people cross-compiling, or using another compiler like clang).
sipa commented at 6:11 PM on May 8, 2016: contributor

@theuni Looks good (theuni@1fecd72)
sipa commented at 4:24 PM on May 25, 2016: contributor

@theuni Feel like PR'ing the above commit?
theuni commented at 9:21 PM on May 25, 2016: contributor

@sipa Yes, will do.
laanwj commented at 9:06 AM on June 29, 2016: member

Closing in favor of #399
laanwj closed this on Jun 29, 2016
egyptianbman referenced this in commit f8b61f527d on May 29, 2018
egyptianbman referenced this in commit 4e62610c86 on May 29, 2018
egyptianbman referenced this in commit e454964ded on May 29, 2018

Contributors