Suppress unused variable warning in automated test #382

pull Lewuathe wants to merge 1 commits into bitcoin-core:master from Lewuathe:suppress-unused-variable-warn changing 1 files +6 −6

Lewuathe commented at 1:50 PM on March 8, 2016: none

max_scalar is only used when OpenSSL test is disabled.

Running test/bitcoin-util-test.py...
  CC       src/tests-tests.o
src/tests.c:3487:32: warning: unused variable 'max_scalar' [-Wunused-variable]
    static const unsigned char max_scalar[32] = {
                               ^
1 warning generated.

relates to: https://github.com/bitcoin/bitcoin/pull/7653

Suppress unused variable warning in automated test

`max_scalar` is only used when OpenSSL test is disabled.

```c++
Running test/bitcoin-util-test.py...
  CC       src/tests-tests.o
src/tests.c:3487:32: warning: unused variable 'max_scalar' [-Wunused-variable]
    static const unsigned char max_scalar[32] = {
                               ^
1 warning generated.
```

6a28dfce39

apoelstra commented at 4:01 PM on April 26, 2016: contributor

This causes a a "mixed declarations and code error" when openssl is available.

Recommend instead adding another set of #ifdef guards around the original location of this variable definition.
sipa commented at 5:58 PM on May 8, 2016: contributor

Agree with @apoelstra.
sipa commented at 4:24 PM on May 25, 2016: contributor

@Lewuathe Feel like addressing @apoelstra's comment?
afk11 cross-referenced this on Jul 5, 2016 from issue configure: add flag to disable OpenSSL tests by apoelstra
apoelstra commented at 8:26 AM on July 6, 2016: contributor

Superceded by #403
apoelstra closed this on Jul 6, 2016

Contributors

Lewuathe

apoelstra

sipa

Linked (view graph)

#403 configure: add flag to disable OpenSSL tests